Fix DrmOutputOptions.ConnectorTypeId naming #15710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
feature
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
|
Enforcing API conventions most definitely isn't nitpicking. Even at the application level. For a framework it's a fundamental requirement. |
kekekeks
approved these changes
May 14, 2024
grokys
pushed a commit
that referenced
this pull request
Jun 3, 2024
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR renames
DrmOutputOptions.ConnectorType_Id(introduced in #14878) toConnectorTypeId.The underscore doesn't respect the standard .NET naming style at all.
While code style is subject to discussion, I believe public API members should respect the established platform naming.
I'm aware this can be considered nitpicking, so feel free to close if needed.
I've also changed the
initsetters tosetones instead since that's what the other properties use. IMO, we should aim for consistency first and discuss separately whether we want all options to besetorinit.Breaking changes
Yes if updating from 11.1.0-beta2, but it's a new property as far as stable versions are concerned.