Deploy RC 333 to Prod #9603
Merged
Deploy RC 333 to Prod #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AnalyticsEventsDocumenter for symbol event names * Update comment, capture group **Why**: The regex got tripped up by a method call on multiple lines changelog: Internal, Documentation, Update source parsing for analytics events documentation
* Add initial code for new exit section on SSN page * Use SsnPresenter * Add step_indicator_steps to ssn_presenter * Add Spanish and French translations * Add step argument to cancel url for analytics (and add feature spec) * changelog changelog: User-facing Improvements, Identity Verification SSN entry page, Add a paragraph and cancel link for users who do not have an SSN * Change h3 to h2 to correct accessibility violation * Style the h2 like an h3 * Lower case n in Social Security number * Add comments to shared ssn template --------- Co-authored-by: John Maxwell <[email protected]> Co-authored-by: Doug Price <[email protected]>
Accidentally committed this as part of #9545 [skip changelog]
changelog: Internal, Console, Update console prompt to include environment name
* LG-11442: put back changes that remove section from screen. * LG-11442: add flag and inject into FeatureFlag context, conditional rendering on document-steps and document-capture-review-issues. changelog: User-Facing Improvements, Doc Auth, Optional exit survey questions. * LG-11442: fix config item name. * LG-11442: fix test. * LG-11442: config test with flag.
If the user has not acknowledged their personal key, don't show the "You already verified your identity" screen, but redirect them to ensure they get their personal key. changelog: Bug Fixes, Identity verification, Redirect to personal key page rather than telling the user they already verified their identity.
* Refine GPO expiration job + rake task - Make the rake task invoke the job's .perform method directly - Note earliest + latest timestamps found in rake task output - Add configurable statement timeout to job [skip changelog] * Allow configuring statement timeout via ENV * Don't allow sql injection (Fix brakeman warning)
**Why**: Add additional clarity changelog: Internal, Console, Update console prompt to include environment name --------- Co-authored-by: Matt Hinz <[email protected]>
…reference). (#9578) changelog: User-Facing Improvements, Doc Auth, Return to account home.
**Why**: Committing this to source code means that if we refactor the AAMVA code, this spec will force us to update this script to keep it up to date * Refactor into two bin scripts, update testing changelog: Internal, Testing, Add AAMVA test script covered by specs
In #9509 we added the ability to specify which profile to fetch PII from when reading PII from the session. This commit applies that capability to the OpenID Connect UserInfo endpoint to ensure that only the active profile's PII is used there. The user info endpoint is used by service providers to access PII after auth. As a result it is not a request made by users and does not have a user session. To read PII we use the out-of-band session accessor's `#load_pii` method. This commit adds a `profile_id` arg to that method and passes in the active profile's ID when reading PII. changelog: Internal, Active-pending profile, The active profile is now read from the session on the userinfo endpoint.
…en (#9599) In #9509 we added the ability to specify which profile to fetch PII from when reading PII from the session. This commit uses the active profile's ID to fetch PII on the completions screen. The completions screen should always be showing PII of the active profile. changelog: Internal, Active-Pending profile, The active profile's PII is displayed on the completions screen.
* create setup and sign in piv cac files * remove login and setup label changelog: Internal, Presenter improvements, break up PIV/CAC presenter * make changes in configuration and two fact options presenter * create setup piv cac selection presenter * test for sign in piv cac selection presenter * run the build again * modify set up piv_cac_selection_presenter and spec * delete piv_cac_presenter, modify two factor login options presenter * more fixing up two factor login options presenter spec * more changes for piv cac setup and sign in presenters * modify for set up piv cac selection * mess with setup selection presenter some more * fix setup test * delete `configuration` from test
…ocument capture (#9593) * add undo_step to step_info Added to FlowPolicy :undo_step_from which invalidates all of the next steps in the flow if a user clicks submit after using the back button. Co-authored-by: Doug Price <[email protected]> Co-authored-by: Sonia Connolly <[email protected]> * add spec for flow_policy#undo_steps_from! & add to welcome controller #update * agreement step undo_steps_from! * add undo_steps_from! to update methods * add changelog changelog: Internal, IdV Back Button, undo future steps * Add undo_step_validation to list of validations Co-authored-by: Matt Hinz <[email protected]> * Add helper method to IdvStepConcern to keep flow_policy private * Fix specs affected by clearing future step info * Add undo_steps_from_controller! helper method to IdvStepConcern It gets the controller name with step.class, and then FlowPolicy can get the key from the controller name. * Rename undo_steps_from_controller! to clear_invalid_steps! * Update undo_step for link_sent and how_to_verify controllers * Check class inheritance with < Co-authored-by: Zach Margolis <[email protected]> --------- Co-authored-by: Doug Price <[email protected]> Co-authored-by: Sonia Connolly <[email protected]> Co-authored-by: Matt Hinz <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
* fix: Gemfile & Gemfile.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-RACK-1061917 * Add changelog changelog: Internal, Dependencies, Update dependencies to latest versions * Fix bundled-with version in Gemfile.lock --------- Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Zach Margolis <[email protected]>
* Start writing idv_session.personal_key_acknowledged We don't currently track that the user has acknowledged their personal key. [skip changelog] * acknowledge_personal_key! We mean it!
**Why**: Provides additional clarity, makes it harder to mix up than ordered arguments changelog: Internal, Source code, Refactor source code
This reverts commit 8240c4b.
* add update route * redirect update btn on verify info pg to controller address pg * add more before actions to handle routing * mark fsm step completed in controller * update address controller spec with update tests * update address controller and spec * update before action and specs * update state id step to fix spec * allow error to be shown on pg * add submitted values on success * add invalid submission spec * update in person spec * lint fix * lint fix * update address controller spec * updates based on feedback * remove before action for ssn step needed and mark address step complete * fix back link issue * remove unused consts * remove address controller flag from in person spec * getting flow path from idv_session for analytics * clean up address controller spec * update verify info controller spec to get flow path from idv sess
**Why**: Provides additional clarity, makes it harder to mix up than ordered arguments changelog: Internal, Source code, Refactor source code for session accessor
aduth
approved these changes
Nov 16, 2023
Good catches! Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal