Fix AnalyticsEventsDocumenter for symbol event names #9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: The regex got tripped up by a method call on multiple lines changelog: Internal, Documentation, Update source parsing for analytics events documentation
mitchellhenke
approved these changes
Nov 13, 2023
Merged
aduth
reviewed
Nov 16, 2023
| def extract_event_name(method_object) | ||
| m = /track_event\(\s*[:"'](?<event_name>[^"']+)["',)]/.match(method_object.source) |
There was a problem hiding this comment.
Was the problem more that the negated [^"']+ didn't include the comma from the following character set ["',)]?
i.e.
- m = /track_event\(\s*[:"'](?<event_name>[^"']+)["',)]/.match(method_object.source)
+ m = /track_event\(\s*[:"'](?<event_name>[^"',]+)["',)]/.match(method_object.source)Alternatively we could change that capture from greedy to lazy:
- m = /track_event\(\s*[:"'](?<event_name>[^"']+)["',)]/.match(method_object.source)
+ m = /track_event\(\s*[:"'](?<event_name>.+?)["',)]/.match(method_object.source)There was a problem hiding this comment.
Technically a comma would be valid inside the string of an event name, so I didn't want to try that. But realistically that would work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Why: The regex got tripped up by a method call on multiple lines
See screenshot below,
idv_enter_password_submittedgot parsed as:👀 Screenshots