Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AAMVA test scripts #9588

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Adds AAMVA test scripts #9588

merged 3 commits into from
Nov 15, 2023

Conversation

zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Nov 14, 2023

🎫 Ticket

Action item from incident review

🛠 Summary of changes

Adds two new scripts for AAMVA:

  1. bin/aamva-test-cert --auth-url=URL --verification-url=URL which does the cert testing (sends in "test cert" mode)
  2. bin/aamva-test-connectivity which just sends fake Jonny Proofs data, can be used to testing connectivity to detect an outage

**Why**: Committing this to source code means that if we refactor the
AAMVA code, this spec will force us to update this script to keep
it up to date

changelog: Internal, Testing, Add AAMVA test script covered by specs
@zachmargolis zachmargolis requested a review from a team November 14, 2023 18:44
end

# This script can be run against the DLDV test environment (with the correct URLs)
subject(:run_script) do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another idea would be to put this in scripts/ dir something, so the script itself and the test are separate? but this seemed easy enough since the expectation is that we'd copy-paste most of this in the console anyways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be quicker to find in the scripts directory while in the middle of an incident. And your comment talks about running it in the DLDV test env. This also works in prod, right?

Is this the Jonny Proofer data, or is that somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was focused on having a DLDV test cert script, rather than a script we could use to check connectivity in prod, so now I think there are two modes that we could use:

  1. DLDV auth test
  2. one-off "jonny proofs" test to check prod connectivity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a big refactor in f827639, now we have two scripts:

  • bin/aamva-test-cert --auth-url=URL --verification-url=URL which does the cert testing
  • bin/aamva-test-connectivity which just sends Jonny Proofs

@zachmargolis zachmargolis changed the title Adds a AAMVA test script Adds AAMVA test scripts Nov 14, 2023
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I haven't tested either of these. Seems like we could let it deploy and then test.

@zachmargolis zachmargolis merged commit 150404e into main Nov 15, 2023
2 checks passed
@zachmargolis zachmargolis deleted the margolis-aamva-cert-spec branch November 15, 2023 16:46
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants