-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AAMVA test scripts #9588
Adds AAMVA test scripts #9588
Conversation
**Why**: Committing this to source code means that if we refactor the AAMVA code, this spec will force us to update this script to keep it up to date changelog: Internal, Testing, Add AAMVA test script covered by specs
spec/scripts/aamva_cert_spec.rb
Outdated
end | ||
|
||
# This script can be run against the DLDV test environment (with the correct URLs) | ||
subject(:run_script) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another idea would be to put this in scripts/
dir something, so the script itself and the test are separate? but this seemed easy enough since the expectation is that we'd copy-paste most of this in the console anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it would be quicker to find in the scripts directory while in the middle of an incident. And your comment talks about running it in the DLDV test env. This also works in prod, right?
Is this the Jonny Proofer data, or is that somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was focused on having a DLDV test cert script, rather than a script we could use to check connectivity in prod, so now I think there are two modes that we could use:
- DLDV auth test
- one-off "jonny proofs" test to check prod connectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made a big refactor in f827639, now we have two scripts:
bin/aamva-test-cert --auth-url=URL --verification-url=URL
which does the cert testingbin/aamva-test-connectivity
which just sends Jonny Proofs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the caveat that I haven't tested either of these. Seems like we could let it deploy and then test.
🎫 Ticket
Action item from incident review
🛠 Summary of changes
Adds two new scripts for AAMVA:
bin/aamva-test-cert --auth-url=URL --verification-url=URL
which does the cert testing (sends in "test cert" mode)bin/aamva-test-connectivity
which just sends fake Jonny Proofs data, can be used to testing connectivity to detect an outage