-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applying accepted v3 filesEditOptions enhancements to v2 #2029
Conversation
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
packages/imperative/src/imperative/src/plugins/utilities/npm-interface/uninstall.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2029 +/- ##
==========================================
+ Coverage 91.04% 91.06% +0.01%
==========================================
Files 636 636
Lines 18953 18953
Branches 3973 3973
==========================================
+ Hits 17256 17259 +3
+ Misses 1696 1693 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
packages/cli/__tests__/zosfiles/__unit__/edit/Edit.utils.unit.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ATorrise for applying this enhancement to v2 and updating the description of --editor
option for consistency!
What It Does
Copying changes from v3 to v2
Review Checklist
I certify that I have: