Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying accepted v3 filesEditOptions enhancements to v2 #2029

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented Jan 29, 2024

What It Does
Copying changes from v3 to v2

Review Checklist
I certify that I have:

Sorry, something went wrong.

Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise changed the title copying over changes from v3, still need to update tests applying accepted v3 filesEditOptios enhancements to v2 Jan 29, 2024
@ATorrise ATorrise marked this pull request as ready for review January 29, 2024 15:54
@ATorrise ATorrise changed the title applying accepted v3 filesEditOptios enhancements to v2 applying accepted v3 filesEditOptions enhancements to v2 Jan 29, 2024
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise requested review from t1m0thyj, awharn, KevinLoesch1, a team, zFernand0 and gejohnston and removed request for t1m0thyj, awharn and a team January 29, 2024 16:03
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88120da) 91.04% compared to head (8e0b70e) 91.06%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
+ Coverage   91.04%   91.06%   +0.01%     
==========================================
  Files         636      636              
  Lines       18953    18953              
  Branches     3973     3973              
==========================================
+ Hits        17256    17259       +3     
+ Misses       1696     1693       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Amber Torrise <[email protected]>
Signed-off-by: Amber Torrise <[email protected]>
@ATorrise ATorrise requested a review from awharn January 30, 2024 17:15
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise for applying this enhancement to v2 and updating the description of --editor option for consistency!

@ATorrise ATorrise added the release-minor Indicates a minor feature has been added label Jan 31, 2024
@ATorrise ATorrise merged commit f9c02b7 into master Jan 31, 2024
19 checks passed
@ATorrise ATorrise deleted the v2addEditOptions branch January 31, 2024 15:03
@github-actions github-actions bot removed the release-minor Indicates a minor feature has been added label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

files edit commands should support binary and encoding options
4 participants