addEditOptions

[ATorrise]

What It Does
Adds the ability to specify that the file should be downloaded as --binary or in a specific --encoding with added options.

How to Test

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37bf907) 91.00% compared to head (9d6ad48) 91.00%.
Report is 2 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2027   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         635      635           
  Lines       18601    18601           
  Branches     3866     3866           
=======================================
  Hits        16928    16928           
  Misses       1672     1672           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ATorrise]

@t1m0thyj @zFernand0 do I have to add tests for these new options? wondering because the edit option is essentially performing

zowe-cli/packages/cli/src/zosfiles/edit/Edit.utils.ts

Lines 167 to 178 in f937576

	if(lfFile.fileType === 'uss'){
	lfFile.zosResp = await Download.ussFile(...args);
	lfFile.encoding = args[2].encoding;
	}else{
	lfFile.zosResp = await Download.dataSet(...args);
	}
	if (useStash){
	await this.destroyTempFile(path.posix.join(tmpdir(), "toDelete.txt"));
	}
	return lfFile;
	}

don't the download tests cover this? ie:

zowe-cli/packages/cli/__tests__/zosfiles/__unit__/download/ds/Dataset.handler.unit.test.ts

Line 166 in f937576

it("should download a single data set in binary mode if requested", async () => {

[t1m0thyj]

Looks pretty good @ATorrise, left a few comments 🙂

[traeok]

LGTM, thanks @ATorrise!

[t1m0thyj]

Thanks for addressing my previous comments :) Found a minor issue when testing.

made requested changes

[zFernand0]

LGTM! 😋
Tested locally and works perfectly fine!
I don't think we must have system tests specific to these options.
They seem self explanatory and we are properly forwarding them to z/OSMF 😋

I'm fine if you want to take a moment to write some though 😋

[t1m0thyj]

LGTM, thanks @ATorrise!

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Release succeeded for the next branch. 🎉

The following packages have been published:

• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]
• npm: @zowe/[email protected]

_{Powered by Octorelease 🚀}