-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to davisagli-py-3 branch #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what's the intent of the changes but from code level the look okay to me.
@davisagli if you are committing to this branch it might have sense to merge this branch into your (the original one I did not want to mess up). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this branch is no longer needed. I manually merged the minimum changes necessary to make all tests pass on the davisagli-py3 branch. I would like to merge that branch into master this week at the sprint in Halle, all further work can then branch off master again.
Thanks! Probably some of the changes are still needed to have Products.CMFCore tests green, but we can't sort this out the next week. |
Tests are actually all green in CMFCore: zopefoundation/Products.CMFCore#42. That is ready to merge as well. |
The tests are green because they are using this branch: https://github.com/zopefoundation/Products.CMFCore/pull/42/files#diff-a55fc4e553af13234f26342646b88e19R19 :) |
Closing the pull request, I pulled all I needed from that branch. |
Thanks for sorting that out, @dataflake |
No description provided.