Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Py3 compat #42

Merged
merged 31 commits into from
May 16, 2018
Merged

[WIP] Py3 compat #42

merged 31 commits into from
May 16, 2018

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 9, 2018 •
edited
Loading

ale-rt added 16 commits April 9, 2018 23:46
@ale-rt
Make test -t test_actions pass on Py3
6969876
@ale-rt
Make test -t test_cachingpolicymgr pass on Py3
d9e755d
@ale-rt
Change branch to davisagli-py3-extension-1
2dc11b0
@ale-rt
Make the test -t test_catalog pass
6567ff9
@ale-rt
Make the test -t test_contenttyperegistry pass
e85d55a
@ale-rt
Make the test -t test_cookieauth pass
8362f64
@ale-rt
Make the test -t test_mailhost pass
683c364
@ale-rt
Make the test -t test_memberdata pass
d70019d
@ale-rt
Branch was merged
66e7b06
@ale-rt
Fix policy Products/CMFCore/tests/test_CachingPolicyManager.py tests
1964f4f
@ale-rt
Fix Products/CMFCore/exportimport/tests/test_workflow.py tests
f71f6c6
@ale-rt
Fix Products/CMFCore/exportimport/tests/test_typeinfo.py tests
8d311b5
@ale-rt
Fix Products/CMFCore/exportimport/tests/test_skins.py tests
7842a01
@ale-rt
Fixup undefined variable
747ca36
@ale-rt
Use updated branch
0194ef7
@ale-rt
Fix Products/CMFCore/exportimport/tests/test_properties.py tests
052100d
@icemac
Copy link
Member Author

icemac commented Apr 19, 2018

@ale-rt Thank you for your hard work fixing the Python 3 compatibility of this package. Currently this PR has failures on Python 2.7 (that's why the checks have been marked as failed by TravisCI). Could you please look into these failures and possibly fix them to get back the green baseline?

@icemac icemac mentioned this pull request Apr 20, 2018
Closed
4 tasks
@icemac
Copy link
Member Author

icemac commented Apr 27, 2018

Wow, the Python 3 tests are now green. 😁 But there are some failures on Python 2. 😢

@ale-rt
Copy link
Member

ale-rt commented Apr 27, 2018

Yeah, I know @icemac... unluckily I had not time to spend on this task, but I hope I can have both fixed soon :)

@ale-rt ale-rt mentioned this pull request Apr 27, 2018
Closed
@ale-rt ale-rt mentioned this pull request Apr 28, 2018
Closed
ale-rt and others added 5 commits May 1, 2018 15:02
@ale-rt
Do not assume utf8 all the time
9709120
@ale-rt
Use Zope master
4ef9843
@ale-rt
Fixup urls
81afe02
@ale-rt
Share mr.developer src
cf75daf
Require successful tests on Python 3:
51588b2 
* Test Python 3.5 and 3.6.
* Add them as supported versions.
* Clean up buildout.cfg and tox.ini.
@icemac icemac requested a review from dataflake May 8, 2018 07:04
@icemac
Copy link
Member Author

icemac commented May 8, 2018

Currently there is a test failing because a value is no longer bytes. Can this be safely changed to str?

@icemac icemac mentioned this pull request May 8, 2018
Closed
@ale-rt
Copy link
Member

ale-rt commented May 8, 2018

I think yes, 'Bar' can be a native string in all the Python versions.
If you want change it, otherwise I will take care of this later today or tomorrow

dataflake
dataflake approved these changes May 13, 2018
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Too bad Products.GenericSetup itself still fails Python 3 tests, even on the branch specified here.

@dataflake
Copy link
Member

Once zopefoundation/Products.GenericSetup#51 is merged (hopefully this week in Halle at the latest) I can make a release of GenericSetup and CMFCore.

@dataflake dataflake mentioned this pull request May 14, 2018
Closed
@dataflake dataflake self-assigned this May 15, 2018
@dataflake dataflake merged commit 213e83f into master May 16, 2018
@dataflake dataflake deleted the py3-compat branch May 16, 2018 15:20
@ale-rt
Copy link
Member

ale-rt commented May 16, 2018

Thanks a lot @dataflake and all the other sprinters for the work you are doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

Assignees

@dataflake dataflake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@icemac @ale-rt @dataflake @pbauer