Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

add more complete Less support #959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghatchue
Copy link

This patch adds Less support; it is based on the patch from @lexaficus, with some bug fixes added. The other pull request is currently on hold due to a merge issue, so I decided to create an new one for these changes.
This patch adds the following features/fixes that were not in the original patch:

  • When using Less, there is a prompt to let users decide whether to use the Less version of Bootstrap, or the regular CSS version
  • Bootstrap stylesheets were included twice in the original patch. In the Less stylesheet via (@import .../bootstrap.less), and also in index.html via the wiredep plugin (bower:css). This is fixed with this patch.
  • Wiredep is also better integrated with Less in this patch. I added a bower:less in the generated Less stylesheet.
  • Other cleanup in _Gruntfile.js (e.g. The copy:styles task is not generated when using Sass or Less, fonts files are assembled in the default bootstrap folders: /fonts/ when using the Less version of Bootstrap, /fonts/bootstrap/ when using the Sass version of bootstrap; Having font files in /dist/bower_components/... is very out of place in a distribution folder.)

@arthurvr
Copy link
Member

I personally don't like more options, honestly. @eddiemonge WDYT?

@eddiemonge
Copy link
Member

my goal was to rewrite so people could compose it and add their own things like this but I ran out of time. I may revisit that idea soon though

@@ -1,91 +0,0 @@
<% if (compassBootstrap) { %>$icon-font-path: "../bower_components/bootstrap-sass-official/assets/fonts/bootstrap/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this whole file removed?

@eddiemonge
Copy link
Member

If you resolve the conflicts and update the commit message to follow the contributing guideline I'll land this pr

@harm-less
Copy link

This feature would be what I need, great work @ghatchue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants