Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

feat(gen): add Less support to the initialization process #637

Closed
wants to merge 1 commit into from
Closed

feat(gen): add Less support to the initialization process #637

wants to merge 1 commit into from

Conversation

a5i
Copy link

@a5i a5i commented Mar 31, 2014

Less question will show up only Compass have been disabled

Review on Reviewable

kingcody referenced this pull request in kingcody/generator-angular-fullstack Apr 6, 2014
kingcody referenced this pull request in kingcody/generator-angular-fullstack Apr 6, 2014
@eddiemonge
Copy link
Member

Im keeping this on the backburner for now but it is something that will get added

message: 'Would you like to use Less?',
default: true,
when: function (props) {
return ! this.compass;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space after !

@eddiemonge
Copy link
Member

@lexaficus see my comments above

@renlord
Copy link

renlord commented May 15, 2014

Hi, just wondering if this will be merged soon?

@eddiemonge
Copy link
Member

only if the issues are resolved

@matiasalvarez87
Copy link

Hi, which are the pending issues? Didn't comments were resolved?

@eddiemonge
Copy link
Member

they have been resolved now. @lexaficus can you squash the commits into one please? Still need to test these changes as well though

@a5i
Copy link
Author

a5i commented May 31, 2014

Ok, done

@passy
Copy link
Member

passy commented May 31, 2014

@lexaficus There's a merge conflict with the patch at the moment.

EDIT: s/request/conflict/

@eddiemonge eddiemonge added this to the 0.10.0: The Future milestone Jun 5, 2014
Less question will show up only Compass have been disabled

merge main.less, main.scss, main.css templates into single main.css template
@ddoolin
Copy link

ddoolin commented Oct 29, 2014

This looks to be passing now and well implemented -- just a heads up. This would be awesome to have in the official repo.

@eddiemonge
Copy link
Member

I thought I commented on this :(

@lexaficus Can you please rebase/resolve conflicts and see if this needs updating? I would like to merge it soon.

@eddiemonge eddiemonge modified the milestone: 0.10.0: The Future Jul 24, 2015
@eddiemonge
Copy link
Member

closing in favor of #959

@eddiemonge eddiemonge closed this Jul 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants