New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switches to cross-spawn to fix issues with Windows shells #50

Merged

claudiopro merged 2 commits into workshopper:master from claudiopro:master

Nov 25, 2017

Member

claudiopro commented Feb 28, 2017 •

edited

Loading

Fixes #43, switches to cross-spawn which addresses these issues:

child_process.spawn unable to execute .cmd or .bat commands on Windows
shell: true working only with Node >=v6 (according to cross-spawn; Node docs say it's supported since v4)
Caller has to escape command and arguments when using shell: true


          Switches to cross-spawn to fix issues with Windows shells

f8d61c9

claudiopro requested a review from sethvincent

February 28, 2017 18:01

claudiopro added the bug label

Member Author

claudiopro commented Feb 28, 2017

Actually it was cherry-picked into v4 LTS and v5 too, see nodejs/node#4598. I'll open a PR to clarify this in cross-spawn.

claudiopro requested review from martinheidegger and removed request for sethvincent

February 28, 2017 18:35


          Merge branch 'master' of github.com:workshopper/learn-sass

54fab8b

claudiopro merged commit 54fab8b into workshopper:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug