Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: add shell option to spawn() #4598

Merged
merged 1 commit into from
Jan 27, 2016
Merged

child_process: add shell option to spawn() #4598

merged 1 commit into from
Jan 27, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 9, 2016

This commit adds a shell option, to spawn() and spawnSync(). This option allows child processes to be spawned with or without a shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Closes #1009

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 9, 2016
bnoordhuis
bnoordhuis reviewed Jan 9, 2016
View reviewed changes
lib/child_process.js
if (options && options.shell)
file = options.shell;
// Make a shallow copy so we don't clobber the user's options object
options = util._extend({}, options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4593 is about deprecating util._extend(). Maybe use Object.assign() here?

EDIT: Just a suggestion, feel free to ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use Object.assign(). I was waiting to see how #4593 played out, but the reaction seems to be good, so I'll replace this.

@janicduplessis janicduplessis mentioned this pull request Jan 11, 2016
Closed
@cjihrig cjihrig force-pushed the shell branch 3 times, most recently from ce56f29 to a7c5918 Compare January 11, 2016 17:52
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 11, 2016

@bnoordhuis I've addressed your comments.

@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 11, 2016
@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 11, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1195/

EDIT: Test failed on Windows. Trying again. CI: https://ci.nodejs.org/job/node-test-pull-request/1198/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 11, 2016

CI is all green, but I'd like sign off from @bnoordhuis

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 18, 2016

@bnoordhuis hope you're feeling better. Ping for a review.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 26, 2016

@bnoordhuis sorry, one more ping.

bnoordhuis
bnoordhuis reviewed Jan 26, 2016
View reviewed changes
lib/child_process.js
options = Object.assign({}, options);

if (options.shell) {
const command = [file].concat(args).join(' ');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't double quotes be escaped on Windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I'll add a test for it too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe not:

C:\Users\Colin>cmd.exe /s /c "echo "foo""
"foo"

C:\Users\Colin>cmd.exe /s /c "echo \"foo\""
\"foo\"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I wonder what cmd.exe's algorithm for that is. Counting quotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like the /s enables that behavior - http://stackoverflow.com/questions/9866962/what-is-cmd-s-for

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned something new today. Thanks.

@bnoordhuis
Copy link
Member

Sorry for the delay. Left some comments.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 26, 2016

@bnoordhuis, I think I've addressed all of your comments.

@bnoordhuis
Copy link
Member

LGTM if the CI is happy.

@cjihrig
child_process: add shell option to spawn()
c3bb4b1 
This commit adds a shell option, to spawn() and spawnSync(). This
option allows child processes to be spawned with or without a
shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Fixes: nodejs#1009
PR-URL: nodejs#4598
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@sam-github sam-github mentioned this pull request Dec 29, 2016
Closed
3 tasks
@MylesBorins
Copy link
Contributor

/cc @nodejs/lts
Would we want to include this in a future LTS release for v4.x?

@sam-github
Copy link
Contributor

I'm +1 for back-port, it improves compatibility between the LTS versions.

This was referenced Jan 4, 2017
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Jan 13, 2017
@cjihrig @MylesBorins
child_process: add shell option to spawn()
1c81530 
This commit adds a shell option, to spawn() and spawnSync(). This
option allows child processes to be spawned with or without a
shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Fixes: #1009
PR-URL: #4598
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@cjihrig @MylesBorins
child_process: add shell option to spawn()
f3f57be 
This commit adds a shell option, to spawn() and spawnSync(). This
option allows child processes to be spawned with or without a
shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Fixes: #1009
PR-URL: #4598
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@cjihrig @MylesBorins
child_process: add shell option to spawn()
5824522 
This commit adds a shell option, to spawn() and spawnSync(). This
option allows child processes to be spawned with or without a
shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Fixes: #1009
PR-URL: #4598
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Feb 21, 2017
@MylesBorins
2017-02-21, Version 4.8.0 'Argon' (LTS)
58ab54f 
Notable Changes:

* child_process: add shell option to spawn() (cjihrig)
  #4598
* crypto:
  * add ALPN Support (Shigeki Ohtsu)
    #2564
  * allow adding extra certs to well-known CAs (Sam Roberts)
    #9139
* deps:
  * v8: expose statistics about heap spaces (Ben Ripkens)
    #4463
* fs: add the fs.mkdtemp() function. (Florian MARGAINE)
  #5333
* process:
  * add `externalMemory` to `process` (Fedor Indutny)
    #9587
  * add process.cpuUsage() (Patrick Mueller)
    #10796
MylesBorins added a commit that referenced this pull request Feb 22, 2017
@MylesBorins
2017-02-21, Version 4.8.0 'Argon' (LTS)
49c5ff4 
Notable Changes:

* child_process: add shell option to spawn() (cjihrig)
  #4598
* crypto:
  * add ALPN Support (Shigeki Ohtsu)
    #2564
  * allow adding extra certs to well-known CAs (Sam Roberts)
    #9139
* deps:
  * v8: expose statistics about heap spaces (Ben Ripkens)
    #4463
* fs: add the fs.mkdtemp() function. (Florian MARGAINE)
  #5333
* process:
  * add `externalMemory` to `process` (Fedor Indutny)
    #9587
  * add process.cpuUsage() (Patrick Mueller)
    #10796

PR-URL: #10973
This was referenced Feb 28, 2017
Merged
Closed
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-02-21, Version 4.8.0 'Argon' (LTS)
bddd5cc 
    Notable Changes:

    * child_process: add shell option to spawn() (cjihrig)
      nodejs/node#4598
    * crypto:
      * add ALPN Support (Shigeki Ohtsu)
        nodejs/node#2564
      * allow adding extra certs to well-known CAs (Sam Roberts)
        nodejs/node#9139
    * deps:
      * v8: expose statistics about heap spaces (Ben Ripkens)
        nodejs/node#4463
    * fs: add the fs.mkdtemp() function. (Florian MARGAINE)
      nodejs/node#5333
    * process:
      * add `externalMemory` to `process` (Fedor Indutny)
        nodejs/node#9587
      * add process.cpuUsage() (Patrick Mueller)
        nodejs/node#10796

Signed-off-by: Ilkka Myller <[email protected]>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-02-21, Version 4.8.0 'Argon' (LTS)
2ee49f0 
    Notable Changes:

    * child_process: add shell option to spawn() (cjihrig)
      nodejs/node#4598
    * crypto:
      * add ALPN Support (Shigeki Ohtsu)
        nodejs/node#2564
      * allow adding extra certs to well-known CAs (Sam Roberts)
        nodejs/node#9139
    * deps:
      * v8: expose statistics about heap spaces (Ben Ripkens)
        nodejs/node#4463
    * fs: add the fs.mkdtemp() function. (Florian MARGAINE)
      nodejs/node#5333
    * process:
      * add `externalMemory` to `process` (Fedor Indutny)
        nodejs/node#9587
      * add process.cpuUsage() (Patrick Mueller)
        nodejs/node#10796

Signed-off-by: Ilkka Myller <[email protected]>
@chexxor chexxor mentioned this pull request Mar 14, 2017
Merged
hgwood pushed a commit to hgwood/cross-env that referenced this pull request Mar 15, 2017
feat(spawn): support for quoted scripts
390baad 
Use the shell option of spawn introduced in Node.js 4.8 (see
nodejs/node#4598) to pass the command to the OS shell.
Supersedes kentcdodds#77.

BREAKING CHANGE: Changes the behavior when passed quoted scripts or special characters interpreted
by the shell.
hgwood pushed a commit to hgwood/cross-env that referenced this pull request Mar 15, 2017
feat(spawn): add support for quoted scripts
a459744 
Use the shell option of spawn introduced in Node.js 4.8 (see
nodejs/node#4598) to pass the command to the OS shell.
Supersedes kentcdodds#77.

BREAKING CHANGE: Changes the behavior when passed quoted scripts or special characters interpreted
by the shell.
kentcdodds pushed a commit to kentcdodds/cross-env that referenced this pull request Mar 15, 2017
@hgwood
feat(spawn): add support for quoted scripts
c8679f4 
* feat(spawn): add support for quoted scripts

Use the shell option of spawn introduced in Node.js 4.8 (see
nodejs/node#4598) to pass the command to the OS shell.
Supersedes #77.


* docs(readme): add gotchas

Add Gotchas paragraph about passing variables to multiple scripts.

* docs(readme): add required node version badge

Replace the Prerequisite paragraph by a badge showing the require version of Node.js required to run
cross-env.

* test(spawn): add test for quoted scripts

See #89 (review).


BREAKING CHANGE: Changes the behavior when passed quoted scripts or special characters interpreted by the shell.
@bnoordhuis bnoordhuis mentioned this pull request Mar 29, 2017
Closed
kentcdodds pushed a commit to kentcdodds/cross-env that referenced this pull request Mar 31, 2017
@hgwood
feat(spawn): add support for quoted scripts
ea80021 
* feat(spawn): add support for quoted scripts

Use the shell option of spawn introduced in Node.js 4.8 (see
nodejs/node#4598) to pass the command to the OS shell.
Supersedes #77.


* docs(readme): add gotchas

Add Gotchas paragraph about passing variables to multiple scripts.

* docs(readme): add required node version badge

Replace the Prerequisite paragraph by a badge showing the require version of Node.js required to run
cross-env.

* test(spawn): add test for quoted scripts

See #89 (review).


BREAKING CHANGE: Changes the behavior when passed quoted scripts or special characters interpreted by the shell.
@Vanuan Vanuan mentioned this pull request Sep 12, 2017
Closed
@idanpa idanpa mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @jasnell @bnoordhuis @rvagg @eljefedelrodeodeljefe @MylesBorins @sam-github @mscdex