-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft third deliverable #53
Open
Juanito0894
wants to merge
25
commits into
wizelineacademy:main
Choose a base branch
from
Juanito0894:ft_third_deliverable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ft third deliverable #53
Juanito0894
wants to merge
25
commits into
wizelineacademy:main
from
Juanito0894:ft_third_deliverable
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature progress
project setup
coins screen modification currency detail screen aggregation consumption of missing services
local images are exchanged for online images the use case name is modified according to the correct nomenclature The logic to update the list of ask and bids is modified
update project progress
-room dependency is added -book dao is implemented -function is added to know if the mobile device is connected to the internet or not -the book repository is adjusted to obtain the information remotely or locally -start splash is added -change application icon
-standalone models for room and api
-code documentation is added in all classes of the project -book view is modified
-documentation is added on new functions -the class modification date is updated -view adjustment is made -functions are added to save and obtain the last hour of api consumption
-interface for book detail is added -adjust the version of the database to avoid crash -database migration is added -obtaining book details is adjusted to consult the database first and if the remote api is empty
-improvement in book detail screen -change of colors -lottie and legend are added when there is no data -legend is added when the device does not have internet
…mentation second deliverable preview
-layout adjustment to display cards -logic setting to transform book list to unique and ranked -the user experience when displaying the books is modified
-navigation library is implemented -navigation is changed to nav graph -navigation graph is added -configuration is added
-the design and change of colors is improved -the color of the animation lottie is changed -a refresh is added to update the detail information
-implementation with flow is added to observe when the information in the database changes
-adjust the list to get a map with unique books
-spaces and line breaks in classes are improved -imports are improved to only those necessary in the classes
-versions are placed in variables for better practice
-change of implementation of coroutines to rx java of the books api call is made -add dependencies for rx java and android
-changed the injection of the http client and interceptor for retrofit -documentation is added on the functions that are provided for better understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lintern
-code analysis is added to the project