second deliverable preview #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 7, 2023 17:41
-room dependency is added -book dao is implemented -function is added to know if the mobile device is connected to the internet or not -the book repository is adjusted to obtain the information remotely or locally -start splash is added -change application icon
-standalone models for room and api
-code documentation is added in all classes of the project -book view is modified
-documentation is added on new functions -the class modification date is updated -view adjustment is made -functions are added to save and obtain the last hour of api consumption
-interface for book detail is added -adjust the version of the database to avoid crash -database migration is added -obtaining book details is adjusted to consult the database first and if the remote api is empty
-improvement in book detail screen -change of colors -lottie and legend are added when there is no data -legend is added when the device does not have internet
ricsarabia
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Attention to comments on the first deliverable
-database implementation
-added user-agent interceptor
-extensions are added to models for type conversion
-unit tests of logic models and functions
-improved visuals