ES6: Migrated GeoLocation #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffflorian
suggested changes
Mar 28, 2017
app/script/location/GeoLocation.js
Outdated
| res['lng'] = result.geometry.location.lng; | ||
| let ref = result.address_components; | ||
| for (let i = 0, len = ref.length; i < len; i++) { | ||
| let component = ref[i]; |
There was a problem hiding this comment.
for (let component of result.address_components) {
app/script/location/GeoLocation.js
Outdated
| let component = ref[i]; | ||
| let name = component.long_name || component.short_name; | ||
| for (let j = 0, len1 = component.types.length; j < len1; j++) { | ||
| let type = component.types[j]; |
There was a problem hiding this comment.
for (let type of component.types) {
app/script/location/GeoLocation.js
Outdated
| z.location = (() => { | ||
| const GOOGLE_GEOCODING_BASE_URL = 'https://maps.googleapis.com/maps/api/geocode/json'; | ||
| const API_KEY = 'AIzaSyCKxxKw5JBZ5zEFtoirtgnw8omvH7gWzfo'; | ||
| let _parse_results = results => { |
There was a problem hiding this comment.
let _parse_results = (results) => {
app/script/location/GeoLocation.js
Outdated
| const API_KEY = 'AIzaSyCKxxKw5JBZ5zEFtoirtgnw8omvH7gWzfo'; | ||
| let _parse_results = results => { | ||
| let res = {}; | ||
| let result = results[0]; |
app/script/location/GeoLocation.js
Outdated
| } | ||
| return $.ajax({ | ||
| url: `${GOOGLE_GEOCODING_BASE_URL}?latlng=${latitude},${longitude}&key=${API_KEY}`, | ||
| }).done(response => { |
There was a problem hiding this comment.
})
.done((response) => {
app/script/location/GeoLocation.js
Outdated
| return resolve(_parse_results(response.results)); | ||
| } | ||
| return resolve(); | ||
| }).fail((jqXHR, textStatus, errorThrown) => reject(new Error(errorThrown))); |
ffflorian
approved these changes
Mar 28, 2017
lipis
added a commit
that referenced
this pull request
Mar 28, 2017
* 'dev' of github.com:wireapp/wire-webapp: eslint no-else-return rule (#954) Reenable Firefox 45 for ESR support but disable calling Calling v3 optimizations (WEBAPP-3772) (#937) ES6: Migrated "auth" directory (#947) ES6: Migrated GeoLocation (#951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.