ES6: Migrated "auth" directory #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrmannplatz
suggested changes
Mar 27, 2017
app/script/auth/AuthRepository.js
Outdated
| get_cached_access_token() { | ||
| return new Promise(((resolve, reject) => { | ||
| let access_token = z.util.StorageUtil.get_value(z.storage.StorageKey.AUTH.ACCESS_TOKEN.VALUE); | ||
| let access_token_type = z.util.StorageUtil.get_value(z.storage.StorageKey.AUTH.ACCESS_TOKEN.TYPE); |
app/script/auth/AuthRepository.js
Outdated
| */ | ||
| save_access_token(access_token_data) { | ||
| let expires_in_millis = 1000 * access_token_data.expires_in; | ||
| let expiration_timestamp = Date.now() + expires_in_millis; |
app/script/auth/AuthRepository.js
Outdated
| */ | ||
| _log_access_token_update(access_token_data, expiration_timestamp) { | ||
| let expiration_log = z.util.format_timestamp(expiration_timestamp, false); | ||
| return this.logger.info(`Saved updated access token. It will expire on: ${expiration_log}`, access_token_data); |
app/script/auth/AuthService.js
Outdated
| const POST_ACCESS = { | ||
| RETRY_LIMIT: 10, | ||
| RETRY_TIMEOUT: 500, | ||
| }; |
There was a problem hiding this comment.
could be a static property as well or?
app/script/auth/AuthService.js
Outdated
| return new Promise((resolve, reject) => { | ||
| this.client.request_queue_blocked_state(z.service.RequestQueueBlockedState.ACCESS_TOKEN_REFRESH); | ||
|
|
||
| let config = { |
There was a problem hiding this comment.
could be const as well
herrmannplatz
approved these changes
Mar 27, 2017
lipis
approved these changes
Mar 27, 2017
app/script/auth/AuthRepository.js
Outdated
| key: new_user.label_key, | ||
| value: new_user.label, | ||
| } | ||
| ); |
app/script/auth/AuthRepository.js
Outdated
| return this.renew_access_token(`Schedule for '${time}'`); | ||
| } else { | ||
| return this.logger.info(`Access token refresh scheduled for '${time}' skipped because we are offline`); | ||
| } |
There was a problem hiding this comment.
ffflorian
suggested changes
Mar 28, 2017
app/script/auth/AuthService.js
Outdated
|
|
||
| const _retry = () => { | ||
| return this.post_access(retry_attempt).then(resolve).catch(reject); | ||
| }; |
There was a problem hiding this comment.
const _retry = () => this.post_access(retry_attempt).then(resolve).catch(reject);
app/script/auth/AuthService.js
Outdated
| xhrFields: { | ||
| withCredentials: true, | ||
| }, | ||
| }).done((data) => { |
app/script/auth/AuthService.js
Outdated
| }, | ||
| }).done((data) => { | ||
| resolve(data); | ||
| }).fail((jqXHR, textStatus, errorThrown) => { |
ffflorian
approved these changes
Mar 28, 2017
lipis
added a commit
that referenced
this pull request
Mar 28, 2017
* 'dev' of github.com:wireapp/wire-webapp: eslint no-else-return rule (#954) Reenable Firefox 45 for ESR support but disable calling Calling v3 optimizations (WEBAPP-3772) (#937) ES6: Migrated "auth" directory (#947) ES6: Migrated GeoLocation (#951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Screenshot