Gruntfile.coffee → Gruntfile.js #885

bennycode · 2017-03-14T11:11:08Z

Type of change

Screenshot

ffflorian · 2017-03-14T11:31:41Z

Gruntfile.js

+
+'use strict';
+
+module.exports = grunt => {


Let's stick to consistency:

module.exports = (grunt) => {

instead of

module.exports = grunt => {

Like in line 119.

ffflorian · 2017-03-14T11:32:15Z

Gruntfile.js

+  // Test Related
+  grunt.registerTask('test', () => grunt.task.run(['clean:docs_coverage', 'scripts', 'test_init', 'test_prepare', 'karma:test']));
+
+  grunt.registerTask('test_prepare', function(test_name) {


Why not (test_name) => ?

ffflorian · 2017-03-14T11:32:34Z

Gruntfile.js

+
+  grunt.registerTask('test_init', ['prepare_dist', 'prepare_test']);
+
+  grunt.registerTask('test_run', test_name => {


Here also

(test_name) => {

ffflorian · 2017-03-14T12:01:42Z

Gruntfile.js

+    if (target === 'prod' || target === 'staging') {
+      return grunt.task.run(`set_version:${target}`, 'init', `prepare_${target}`, 'aws_prepare');
+    } else if (target === 'dev') {
+      return grunt.task.run("set_version:staging", 'init', "prepare_staging", 'aws_prepare');


' instead of "

ffflorian · 2017-03-14T12:02:05Z

Gruntfile.js

+    const app_files = prepare_file_names(scripts.app);
+    const component_files = prepare_file_names(scripts.component);
+    const vendor_files = prepare_file_names(scripts.vendor);
+    const test_files = test_name ? ["../test/js/#{test_name}Spec.js"] : ['../test/**/*Spec.js'];


' instead of "

lipis · 2017-03-14T12:08:38Z

First of all I'm 100% with the team to move away from CoffeeScript, even though I used to be a big supporter of it and the main influencer for this choice in this project. But times have changed and CoffeeScript is keeping us behind, as we can't use the latest and greatest features of JavaScript.

Having said that, I'm just a little bit against the timing of it. We should probably update the build scripts as a last step, instead of first.

Here is why:

The majority of our users/contributors don't care about the build scripts, but the source code
We should spend our time on getting rid of CoffeeScript in the source code
Once everything is in pure JS we can drop CoffeeScript by updating the build scripts as a final step, because:
- These files are changed very rarely
- Almost 100% of these files are consisting of variables, JSON objects and comments
- CSON is much easier to read/manipulate than JSON and there is no need to declare variables in CoffeeScript
- Readability for better maintenance is actually the main reasons of CS to exist at all
- It already works, so no risk involved by updating a very important piece of the puzzle
- No need to spend valuable resources at the moment
- If refactoring we should maybe even drop Grunt and switch to Gulp (modern, better, faster)?!

What should we do instead

Since #883 is already merged my vote is to do the following in that order:

All the new files should be written in pure JS
Create a new issue where we point out to all folders in script directory as checkboxes to track the progress
Update Grunt files to JavaScript
Remove CoffeeScript from the dependencies of this project

bennycode · 2017-03-14T12:27:43Z

@lipis, dropping CoffeeScript means dropping CoffeeScript.

It doesn't matter with which files we start our "CoffeeScript to JavaScript" movement because by the end of this movement, there will be no more CoffeeScript.

To start I just picked a file with little logic (which is Gruntfile.coffee). It was very easy to transpile Gruntfile.coffee because it doesn't use much CoffeeScript sugar. The main parts were:

1.

prepare_file_names = (file_name_array) =>
  return (file_name.replace 'deploy/', '' for file_name in file_name_array)

→

const prepare_file_names = (file_name_array) => {
  return file_name_array.map(file_name => file_name.replace('deploy/', ''));
};

2.

test_files = if test_name then ["../test/js/#{test_name}Spec.js"] else ['../test/**/*Spec.js']

→

const test_files = test_name ? ['../test/js/#{test_name}Spec.js'] : ['../test/**/*Spec.js'];

Everything else I just throwed into js2.coffee and from there into Lebab. Afterwards I executed eslint Gruntfile.js --fix. Done!

P.S. I know that it hurts letting things go. But in the end it's the birth of something new. 🌻

lipis · 2017-03-14T12:38:09Z

Sure and I don't mind letting it go.. It's done, dead, kaput, null. All I'm saying is that we just have to attack it from the other side :)

ffflorian · 2017-03-14T13:00:15Z

🎉

bennycode added 3 commits March 14, 2017 12:11

Gruntfile.coffee → Gruntfile.js

38f79ef

Removed "Gruntfile.coffee"

03fec45

chore()

d2b9f98

lipis requested review from lipis, herrmannplatz and gregor March 14, 2017 11:17

ffflorian suggested changes Mar 14, 2017

View reviewed changes

chore()

fa843e7

ffflorian suggested changes Mar 14, 2017

View reviewed changes

eslint Gruntfile.js --fix

eee441a

ffflorian approved these changes Mar 14, 2017

View reviewed changes

Merge branch 'dev' into es6-gruntfile

ccfcbad

Merge branch 'dev' into es6-gruntfile

5a66846

bennycode merged commit ebfd566 into dev Mar 14, 2017

bennycode deleted the es6-gruntfile branch March 14, 2017 12:56

lipis mentioned this pull request Mar 14, 2017

Drop CoffeeScript #891

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gruntfile.coffee → Gruntfile.js #885

Gruntfile.coffee → Gruntfile.js #885

bennycode commented Mar 14, 2017

ffflorian Mar 14, 2017 •

edited

Loading

ffflorian Mar 14, 2017 •

edited

Loading

ffflorian Mar 14, 2017

ffflorian Mar 14, 2017

ffflorian Mar 14, 2017

lipis commented Mar 14, 2017 •

edited

Loading

bennycode commented Mar 14, 2017

lipis commented Mar 14, 2017

ffflorian commented Mar 14, 2017


		grunt.registerTask('test_init', ['prepare_dist', 'prepare_test']);

		grunt.registerTask('test_run', test_name => {

Gruntfile.coffee → Gruntfile.js #885

Gruntfile.coffee → Gruntfile.js #885

Conversation

bennycode commented Mar 14, 2017

Type of change

Screenshot

ffflorian Mar 14, 2017 • edited Loading

Choose a reason for hiding this comment

ffflorian Mar 14, 2017 • edited Loading

Choose a reason for hiding this comment

ffflorian Mar 14, 2017

Choose a reason for hiding this comment

ffflorian Mar 14, 2017

Choose a reason for hiding this comment

ffflorian Mar 14, 2017

Choose a reason for hiding this comment

lipis commented Mar 14, 2017 • edited Loading

Here is why:

What should we do instead

bennycode commented Mar 14, 2017

lipis commented Mar 14, 2017

ffflorian commented Mar 14, 2017

ffflorian Mar 14, 2017 •

edited

Loading

ffflorian Mar 14, 2017 •

edited

Loading

lipis commented Mar 14, 2017 •

edited

Loading