Support JavaScript for writing source files #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennycode
suggested changes
Mar 14, 2017
grunt/config/copy.coffee
Outdated
| cwd: '<%= dir.app_ %>' | ||
| dest: '<%= dir.dist %>' | ||
| expand: true | ||
| src: 'script/*/*.js' |
There was a problem hiding this comment.
Shouldn't script/*/*.js become script/**/*.js?
ffflorian
reviewed
Mar 14, 2017
grunt/config/copy.coffee
Outdated
| @@ -64,6 +71,7 @@ module.exports = | |||
| 'image/**/*' | |||
| 'font/**/*' | |||
| 'style/*.css' | |||
| 'script/*/*.js' | |||
There was a problem hiding this comment.
Shouldn't it be script/**/*.js?
|
browsers! |
ffflorian
approved these changes
Mar 14, 2017
bennycode
approved these changes
Mar 14, 2017
This was referenced Mar 14, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So simply instead of creating
.coffeefiles inside theapp/scriptdirectory we can now create.jsfiles and the rest remain the same.