Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a wdio/selenium config #261

Closed
edg2s opened this issue May 25, 2020 · 2 comments · Fixed by #262
Closed

Consider a wdio/selenium config #261

edg2s opened this issue May 25, 2020 · 2 comments · Fixed by #262

Comments

@edg2s
Copy link
Member

edg2s commented May 25, 2020

Would consist of:

{
	"plugins": [ "wdio" ],
	"extends": [
		"wikimedia/server",
		"plugin:wdio/recommended"
	],
	"env": {
		"mocha": true
	}
}

The wdio plugin just provides a few globals ($, $$, ...) https://github.com/webdriverio/webdriverio/blob/master/packages/eslint-plugin-wdio/index.js

@edg2s
Copy link
Member Author

edg2s commented May 25, 2020

..and maybe eslint-plugin-mocha

edg2s added a commit that referenced this issue May 25, 2020
@edg2s
Copy link
Member Author

edg2s commented May 25, 2020

Rules disabled:

  • mocha/no-hooks-for-single-case - this seems like a silly rule to have in recommended, just because I have one test //now// doesn't mean I shouldn't structure my code to allow for more.
  • mocha/no-mocha-arrows - maybe this can be enabled later, but we don't appear to use the this context at the moment. This rule is very disruptive (but fixable).
  • mocha/no-skipped-tests - again, seems odd this is recommended. The assumption is that skipped tests are for debugging, but that's a big assumption to make.

Known issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant