no-setup-in-describe triggers on describe.skip

[edg2s]

describe.skip( 'My test', () => {
  it( 'Something', () => {
    // Foo
  } );
} );

This should not trigger no-setup-in-describe, yet it does.

This can be worked around by moving the skip to each of the it calls.

[lo1tuma]

Can you explain why it shouldn’t trigger? If the test code is not ready or somehow broken it should be removed. If it is important enough to keep the test code then it should be also important enough to refactor and move the setup code to the appropriate places.

[edg2s]

The rule should only trigger when there is setup code in the describe, and there isn't any.

[lo1tuma]

There is a describe block in your example.

[lo1tuma]

I guess I understand the issue now. I thought this issue was a feature request to skip checking for setup code when using describe.skip(), but it is actually a bug, where describe.skip() triggers this rule even when there is no setup code.

Thanks for reporting. That is definitely a bug.