-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for Wagtail 4.0 #49
Conversation
and adjust the import paths to allow different wagtail versions
I removed the upper limits on wagtail and django versions.
wagtail_ab_testing/wagtail_hooks.py
Outdated
|
||
return '' | ||
else: | ||
def render_html(self, request, context): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: drop support for Wagtail < 2.15 as 2.15 is the LTS and everything before that is long not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the suggestion. Saw you did this yesterday somewhere 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support is now for Wagtail >= 2.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Approving.
Hi, Is it possible to update the Wagtail version in |
Hi Ralph, Thanks for the request. I’m sure that can be done. Any chance you could let us have a pull request for it. |
Hi Nick. Thanks for getting back to me. I'll try and get this done asap. Do you know offhand if this is literally a version number change or should I be looking at other changes made in 4.1 as well? |
It's likely it needs other changes for the tests in the tox.ini as well as the setup.py |
superseded by #52 |
This PR build off of #48 which includes a Wagtail 3 upgrade.
Lets merge that before this one.