Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Wagtail 4.0 #49

Closed
wants to merge 19 commits into from
Closed

Upgrade for Wagtail 4.0 #49

wants to merge 19 commits into from

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Sep 22, 2022

This PR build off of #48 which includes a Wagtail 3 upgrade.

Lets merge that before this one.

@nickmoreton nickmoreton marked this pull request as ready for review September 22, 2022 11:54

return ''
else:
def render_html(self, request, context):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: drop support for Wagtail < 2.15 as 2.15 is the LTS and everything before that is long not supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the suggestion. Saw you did this yesterday somewhere 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support is now for Wagtail >= 2.15

Copy link
Contributor

@katdom13 katdom13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Approving.

@rcoombes-gosh
Copy link

Hi, Is it possible to update the Wagtail version in install_requires of setup.py to cover v4.1 please?

@nickmoreton
Copy link
Contributor Author

Hi, Is it possible to update the Wagtail version in install_requires of setup.py to cover v4.1 please?

Hi Ralph, Thanks for the request. I’m sure that can be done. Any chance you could let us have a pull request for it.
It might be a little while yet before we can get around to it and possibly will be a 4.2 update as well at that point.

@rcoombes-gosh
Copy link

Hi Nick. Thanks for getting back to me. I'll try and get this done asap. Do you know offhand if this is literally a version number change or should I be looking at other changes made in 4.1 as well?

@nickmoreton
Copy link
Contributor Author

Hi Nick. Thanks for getting back to me. I'll try and get this done asap. Do you know offhand if this is literally a version number change or should I be looking at other changes made in 4.1 as well?

It's likely it needs other changes for the tests in the tox.ini as well as the setup.py

@Stormheg
Copy link
Member

Stormheg commented Oct 5, 2023

superseded by #52

@Stormheg Stormheg closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants