-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 3.0 compatibility #48
Conversation
and adjust the import paths to allow different wagtail versions
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major release, right? We need to add the new version number here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the final release number should now be 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nickmoreton, could we change these try-except blocks to use properly checked version imports?
Hey @nickmoreton, this looks good. Did you get a reply from @kaedroho for the updated docs? |
I haven't as yet. Your mention may be the key 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me with the exception of a rogue pytz
import.
@@ -1,7 +1,15 @@ | |||
from django.test import TestCase | |||
from django.urls import reverse | |||
from wagtail.core.models import Page | |||
from wagtail.tests.utils import WagtailTestUtils | |||
from pytz import VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used, should it be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no it's not used is it. I have removed it. Thanks @bcdickinson
Hey @bcdickinson Let me know please if you are happy for me to merge this now and I can then move on with the v4 one |
Oh actually I don't have the correct access to merge it. |
superseded by #52 |
Add support for Wagtail 3.0
Support Ticket: https://projects.torchbox.com/projects/support-team/tickets/463
This also includes Django 4.0 support
It would be good if the example screenshots could be updated. I wonder if @kaedroho might have the original db or fixtures to do that?
Tasks