Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 3.0 compatibility #48

Closed
wants to merge 16 commits into from
Closed

Wagtail 3.0 compatibility #48

wants to merge 16 commits into from

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented May 18, 2022

Add support for Wagtail 3.0

Support Ticket: https://projects.torchbox.com/projects/support-team/tickets/463

This also includes Django 4.0 support

It would be good if the example screenshots could be updated. I wonder if @kaedroho might have the original db or fixtures to do that?

Tasks

  • Update docs
  • Update Change Log

@nickmoreton nickmoreton marked this pull request as ready for review May 19, 2022 12:53
@nickmoreton nickmoreton requested a review from zerolab May 23, 2022 14:22
@zerolab zerolab requested review from kaedroho and removed request for zerolab May 23, 2022 17:56
@nickmoreton nickmoreton requested a review from zerolab May 24, 2022 10:31
@zerolab zerolab removed their request for review May 24, 2022 10:44
testmanage.py Show resolved Hide resolved
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major release, right? We need to add the new version number here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the final release number should now be 1.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool.

testmanage.py Outdated Show resolved Hide resolved
Copy link

@William-Blackie William-Blackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickmoreton, could we change these try-except blocks to use properly checked version imports?

@William-Blackie
Copy link

Hey @nickmoreton, this looks good. Did you get a reply from @kaedroho for the updated docs?

@nickmoreton
Copy link
Contributor Author

Hey @nickmoreton, this looks good. Did you get a reply from @kaedroho for the updated docs?

I haven't as yet. Your mention may be the key 😄

Copy link

@bcdickinson bcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me with the exception of a rogue pytz import.

@@ -1,7 +1,15 @@
from django.test import TestCase
from django.urls import reverse
from wagtail.core.models import Page
from wagtail.tests.utils import WagtailTestUtils
from pytz import VERSION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used, should it be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no it's not used is it. I have removed it. Thanks @bcdickinson

@nickmoreton nickmoreton requested review from bcdickinson and removed request for kaedroho October 4, 2022 08:05
@nickmoreton
Copy link
Contributor Author

Hey @bcdickinson Let me know please if you are happy for me to merge this now and I can then move on with the v4 one

@nickmoreton
Copy link
Contributor Author

Oh actually I don't have the correct access to merge it.

@Stormheg
Copy link
Member

Stormheg commented Oct 5, 2023

superseded by #52

@Stormheg Stormheg closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants