Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

juberti · 2014-10-15T06:23:41Z

Initial version of doohickeys. @alvestrand @stefhak @pthatcherg PTAL and see if you think this is going in the right direction. If so I will deal with the few formatting and link nits remaining.

Details:

addStream/remoteStream/getSenders/getReceivers and associated APIs have now been moved to a new document section (Need API to indicate if temporal or spatial quality is preferred in video compression #5). This allows section Need API to read the CSRC on received tracks #4 to focus on the basics of the PC API, and Need API to indicate if temporal or spatial quality is preferred in video compression #5 to extend it with media functionality and Need API to receive mixer to client audio level information for a track #6 to extend it with data channel functionality.
addStream has become addTrack(MediaStreamTrack track, MediaStream... streams), as discussed in DC. addTrack returns a RTCRtpSender.
removeStream has become removeTrack; removeTrack takes a RTCRtpSender.
onaddstream has become onaddtrack; onremovestream has been removed (now, .onended is fired).
getLocalStreams/getRemoteStreams -> getSenders/getReceivers.

alvestrand · 2014-10-15T08:02:08Z

Good to have this!

Needs a better cover note - the core part in this is the change from
AddStream to AddTrack.

I miss a paragraph on how the track's membership in streams is
signalled in the onaddtrack handler - there doesn't seem to be a
procedure specification for the firing of onaddtrack.

Something like this:

When a PeerConnection object detects that a track has been added by
the remote peer, it performs
the following steps:

- Let TRACK be a new MediaStreamTrack object
- Let STREAMS be the set of stream objects that the TRACK is a member of
- For each stream in STREAMS, construct an AddtrackEvent where

(member variable listing)
- Fire the events at the PeerConnection

Section 5 of draft-ietf-mmusic-msid-07 needs to be consistent with this
document.

On 10/15/2014 08:23 AM, Justin Uberti wrote:

Initial version of doohickeys. @alvestrand
https://github.com/alvestrand @stefhak https://github.com/stefhak
@pthatcherg https://github.com/pthatcherg PTAL and see if you think
this is going in the right direction. If so I will deal with the few
formatting and link nits remaining.
    You can merge this Pull Request by running
git pull https://github.com/juberti/webrtc-pc master

Or view, comment on, or merge it at:

#3
    Commit Summary
Add RTCRtpSender, RTCRtpSender, and friends
File Changes
M webrtc.html
https://github.com/w3c/webrtc-pc/pull/3/files#diff-0 (694)
Patch Links:
https://github.com/w3c/webrtc-pc/pull/3.patch

https://github.com/w3c/webrtc-pc/pull/3.diff
—
Reply to this email directly or view it on GitHub
#3.

pthatcherg · 2014-10-15T16:04:54Z

webrtc.html

@@ -518,7 +509,7 @@
        "component".</p>

        <p>When a user agent has reached the point where a
-        <code><a>MediaStream</a></code> can be created to represent incoming
+        <code><a>MediaStreamTrack</a></code> can be created to represent incoming
        components, the user agent MUST run the following steps:</p>


Does "components" (plural) still make sense?

pthatcherg · 2014-10-15T16:08:57Z

I left a few comments, some grammar. One was about what effect the "...
streams" variable has.

On Tue, Oct 14, 2014 at 11:23 PM, Justin Uberti [email protected]
wrote:

Initial version of doohickeys. @alvestrand https://github.com/alvestrand
@stefhak https://github.com/stefhak @pthatcherg
https://github.com/pthatcherg PTAL and see if you think this is going
in the right direction. If so I will deal with the few formatting and link

nits remaining.

You can merge this Pull Request by running

git pull https://github.com/juberti/webrtc-pc master

Or view, comment on, or merge it at:

#3
Commit Summary

Add RTCRtpSender, RTCRtpSender, and friends

File Changes

M webrtc.html
https://github.com/w3c/webrtc-pc/pull/3/files#diff-0 (694)

Patch Links:

https://github.com/w3c/webrtc-pc/pull/3.patch

https://github.com/w3c/webrtc-pc/pull/3.diff

—
Reply to this email directly or view it on GitHub
#3.

pthatcherg · 2014-10-15T16:09:08Z

Overall, it looks very good, by the way.

On Wed, Oct 15, 2014 at 9:08 AM, Peter Thatcher [email protected]
wrote:

I left a few comments, some grammar. One was about what effect the "...
streams" variable has.

On Tue, Oct 14, 2014 at 11:23 PM, Justin Uberti [email protected]
wrote:

Initial version of doohickeys. @alvestrand
https://github.com/alvestrand @stefhak https://github.com/stefhak
@pthatcherg https://github.com/pthatcherg PTAL and see if you think
this is going in the right direction. If so I will deal with the few

formatting and link nits remaining.

You can merge this Pull Request by running

git pull https://github.com/juberti/webrtc-pc master

Or view, comment on, or merge it at:

#3
Commit Summary

Add RTCRtpSender, RTCRtpSender, and friends

File Changes

M webrtc.html
https://github.com/w3c/webrtc-pc/pull/3/files#diff-0 (694)

Patch Links:

https://github.com/w3c/webrtc-pc/pull/3.patch

https://github.com/w3c/webrtc-pc/pull/3.diff

—
Reply to this email directly or view it on GitHub
#3.

stefhak · 2014-10-16T05:57:40Z

Following up on Harald's part about steps when a PeerConnection object detects that a new track has been added by the remote peer: did we not conclude that the PC would not do this, but since the stream association is part of the addtrack event the application can add the track to the stream (and create the stream if it does not exist yet)?

And as a follow up: did we not say that the stream attribute on the addtrack event should be a list (for the case where a track i member of several MS's on the sending side at the time of doing pc.addTrack(track))?

(I may be remembering completely wrong here)

juberti · 2014-10-16T20:13:10Z

Only tracks added via pc.addTrack are communicated to the remote side.
The remote side can do whatever it wants regarding moving tracks around to different streams.
I think we do create a default stream if none is specified in signaling.
I think the stream attribute has to be a list (I will make the change, although I wonder if the complexity here is worth it - remind me why having tracks in multiple streams is useful?)

juberti · 2014-10-17T06:19:57Z

Fixed AddTrackEvent to handle multiple MediaStreams, and other CR comments. PTAL.

Fix the parameter descriptions for RTCAddTrackEvent

juberti · 2014-10-18T01:46:25Z

Merged in a link fix from @dontcallmedom and also cleaned up AddTrackEvent.

juberti · 2014-10-21T17:53:56Z

Any update on this PR? Would like to land this ahead of next week's meeting.

Also, I have this PR queued up to change updateIce -> setConfiguration.
juberti#2

stefhak · 2014-10-21T20:23:53Z

The editor's are going to have it reviewed by Thu this week, hopefully it can be merged shortly after that.

adam-be · 2014-10-23T13:18:31Z

webrtc.html

+            referenced by the SDP
+            negotiation, creating a new ones if they do not exist. If no
+            MediaStreams are indicated in the SDP negotiation, a default MediaStream
+            is used.</p>


This section needs some work. The algorithm talks about several incoming components. That used to be the case when we were creating a MediaStream with several tracks; now we only have one. Step 3 (not in the diff), should be moved earlier, since it creates the MediaStreamTrack.

OK. I think I addressed these issues.

adam-be · 2014-10-23T13:19:11Z

webrtc.html

+        </dd>
+
+        <dt>readonly attribute sequence&lt;MediaStream&gt; streams</dt>
+


This must be a getter function since a sequence is passed by value.

Copied what you did in your branch.

adam-be · 2014-10-25T11:30:16Z

The stats-example uses pc.getRemoteStreams(). It needs to be updated as well.

adam-be · 2014-10-25T12:21:01Z

I got a task to isolate the new section so it could be reviewed separately. I did some fixes as well that can be found here: https://github.com/adam-be/webrtc-pc/commits/juberti-rtpsr

juberti · 2014-10-27T05:31:02Z

Addressed all comments. PTAL.

juberti · 2014-10-29T03:52:34Z

@alvestrand @adam-be what are the next steps on this?

stefhak · 2014-10-29T04:09:06Z

I know Adam has prepared a version of the spec with these parts included; I think the plan was to send it to the WG before the meetings this week.

dontcallmedom · 2014-10-30T21:18:00Z

webrtc.html

+          <code>receiver</code>.</p>
+        </dd>
+
+         <dt>sequence&lt;MediaStream&gt; getStreams()</dt>


I know the getter comes from a change suggested by @adam-be , but it sounds to me that using a simple attribute with an array rather than a sequence would work just as well (i.e. readonly attribute MediaStream[] streams).

alvestrand · 2015-01-15T13:59:54Z

Obsolete - PR is now #175

Yet another typo (outbund)

Issue 714 oauth credential

Add RTCRtpSender, RTCRtpSender, and friends

ce5794c

juberti changed the title ~~Add RTCRtpSender, RTCRtpSender, and friends~~ Add RTCRtpSender, RTCRtpReceiver, and friends Oct 15, 2014

pthatcherg reviewed Oct 15, 2014
View reviewed changes

juberti changed the title ~~Add RTCRtpSender, RTCRtpReceiver, and friends~~ Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver Oct 15, 2014

Respond to CR comments

dc0b216

juberti added 2 commits October 17, 2014 18:32

Merge anchor fix from @dontcallmedom

9506f8b

AddTrackEvent -> RTCAddTrackEvent

2e0075a

Fix the parameter descriptions for RTCAddTrackEvent

adam-be reviewed Oct 23, 2014
View reviewed changes

PR feedback; onaddtrack -> ontrack

fbf6642

dontcallmedom reviewed Oct 30, 2014
View reviewed changes

juberti mentioned this pull request Oct 31, 2014

Merge juberti:master to doohickey branch #18

Merged

dontcallmedom mentioned this pull request Dec 15, 2014

Streams that become isolated generate errors on PC #133

Closed

alvestrand closed this Jan 15, 2015

adam-be mentioned this pull request Jan 16, 2015

Merge doohickey branch to master #175

Merged

pthatcherg mentioned this pull request Sep 23, 2015

Fix broken RTCPeerConnection's operations array to work with promises. #307

Closed

aboba added a commit that referenced this pull request Oct 22, 2015

Merge pull request #3 from aboba/outbund-typo

5c80ac8

Yet another typo (outbund)

juberti mentioned this pull request Nov 11, 2016

STUN/TURN OAuth token auth parameter passing #714

Closed

aboba pushed a commit that referenced this pull request Mar 16, 2017

Merge pull request #3 from misi/issue_714_oauth_credential

705e111

Issue 714 oauth credential

jan-ivar mentioned this pull request Jun 7, 2017

Do we need a "trackremoved" event? #1161

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

juberti commented Oct 15, 2014

alvestrand commented Oct 15, 2014

pthatcherg Oct 15, 2014

juberti Oct 17, 2014

pthatcherg commented Oct 15, 2014

nits remaining.

pthatcherg commented Oct 15, 2014

formatting and link nits remaining.

stefhak commented Oct 16, 2014

juberti commented Oct 16, 2014

juberti commented Oct 17, 2014

juberti commented Oct 18, 2014

juberti commented Oct 21, 2014

stefhak commented Oct 21, 2014

adam-be Oct 23, 2014

juberti Oct 27, 2014

adam-be Oct 23, 2014

juberti Oct 27, 2014

adam-be commented Oct 25, 2014

adam-be commented Oct 25, 2014

juberti commented Oct 27, 2014

juberti commented Oct 29, 2014

stefhak commented Oct 29, 2014

dontcallmedom Oct 30, 2014

alvestrand commented Jan 15, 2015

		</dd>

		<dt>readonly attribute sequence<MediaStream> streams</dt>

Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

Change addStream to addTrack; add RTCRtpSender/RTCRtpReceiver #3

Conversation

juberti commented Oct 15, 2014

alvestrand commented Oct 15, 2014

pthatcherg Oct 15, 2014

Choose a reason for hiding this comment

juberti Oct 17, 2014

Choose a reason for hiding this comment

pthatcherg commented Oct 15, 2014

nits remaining.

pthatcherg commented Oct 15, 2014

formatting and link nits remaining.

stefhak commented Oct 16, 2014

juberti commented Oct 16, 2014

juberti commented Oct 17, 2014

juberti commented Oct 18, 2014

juberti commented Oct 21, 2014

stefhak commented Oct 21, 2014

adam-be Oct 23, 2014

Choose a reason for hiding this comment

juberti Oct 27, 2014

Choose a reason for hiding this comment

adam-be Oct 23, 2014

Choose a reason for hiding this comment

juberti Oct 27, 2014

Choose a reason for hiding this comment

adam-be commented Oct 25, 2014

adam-be commented Oct 25, 2014

juberti commented Oct 27, 2014

juberti commented Oct 29, 2014

stefhak commented Oct 29, 2014

dontcallmedom Oct 30, 2014

Choose a reason for hiding this comment

alvestrand commented Jan 15, 2015