Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams that become isolated generate errors on PC #133

Closed
dontcallmedom opened this issue Dec 15, 2014 · 9 comments
Closed

Streams that become isolated generate errors on PC #133

dontcallmedom opened this issue Dec 15, 2014 · 9 comments
Assignees

Comments

@dontcallmedom
Copy link
Member

Originally reported on W3C Bugzilla ISSUE-25859 Wed, 21 May 2014 19:34:53 GMT
Reported by Martin Thomson
Assigned to

When a stream becomes isolated (see 25856) we should surface an error and stop sending media for that track (we might have to continue transmission - ask the IETF group - but no content can be sent).

The only exception to this is if the stream is isolated and peerIdentity tagged. Those can potentially be transmitted.

Proposal is:

partial interface RTCPeerConnection : EventTarget {
attribute EventHandler? onerror;
};

[Constructor(TrackIsolatedEventInit args)]
interface TrackIsolatedEvent : Event {
attribute MediaStreamTrack track;
};

Alternatively:

partial interface RTCRtpSender : EventTarget {
attribute EventHandler? onerror;
};

Which might be a little better because the error can be generic.

@dontcallmedom
Copy link
Member Author

Original comment by Harald Alvestrand on W3C Bugzilla. Fri, 31 Oct 2014 17:57:06 GMT

Martin will make PR.

@dontcallmedom
Copy link
Member Author

Original comment by Harald Alvestrand on W3C Bugzilla. Fri, 31 Oct 2014 18:01:22 GMT

This needs some more thinking; not PR-ready.

@dontcallmedom
Copy link
Member Author

Original comment by Adam Bergkvist on W3C Bugzilla. Wed, 05 Nov 2014 10:20:21 GMT

This event can use the MediaStreamTrackEvent interface [1].

[1] http://w3c.github.io/mediacapture-main/#mediastreamtrackevent

@dontcallmedom
Copy link
Member Author

Original comment by Martin Thomson on W3C Bugzilla. Wed, 05 Nov 2014 17:11:59 GMT

(In reply to Adam Bergkvist from comment #3)

This event can use the MediaStreamTrackEvent interface [1].

It doesn't need to. event.target will identify the track since the event is fired at the track.

@dontcallmedom
Copy link
Member Author

Original comment by Adam Bergkvist on W3C Bugzilla. Mon, 10 Nov 2014 13:38:14 GMT

Even better. We can use a simple Event.

@fluffy
Copy link
Contributor

fluffy commented Jul 31, 2015

I don't think this is an enhancement this seems like a pretty key part of how the media privacy works

@alvestrand
Copy link
Contributor

@martinthomson is this still valid?

@martinthomson
Copy link
Member

I think that we discussed having a property and event on tracks that could be used to identify when they are isolated or not.

@dontcallmedom
Copy link
Member Author

The current spec has an isolated attribute and an isolationchange event, so I think this is already solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants