Update media time usage for remote playback protocol. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baylesj
approved these changes
Apr 25, 2024
github-actions bot
added a commit
that referenced
this pull request
May 31, 2024
SHA: 4a988e3 Reason: push, by mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses and closes Issue #327: Representation of time in remote-playback-state
The current spec uses the per-frame media synchronization timestamps to control and update the media playback state and handle other time specific fields. This has a few issues:
Therefore, to align with HTML, we just convert time fields to correspond to the types that are exposed in script on media elements, so that agents don't have to translate to/from media synchronization time. (For cases where conversion is necessary, I added an appendix with a formula to do that.)
The protocol also used "unknown" to represent an unknown value, which does not have meaning in CBOR or CDDL. This PR also updates the protocol to use CBOR
nullinstead which is a primitive value in CBOR.Preview | Diff