Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representation of time in remote-playback-state #327

Closed
markafoltz opened this issue Feb 27, 2024 · 0 comments · Fixed by #328
Closed

Representation of time in remote-playback-state #327

markafoltz opened this issue Feb 27, 2024 · 0 comments · Fixed by #328
Assignees

Comments

@markafoltz
Copy link
Contributor

There are a few things that would simplify the time related fields in remote-playback-state.

Currently they all use media-time which is the internal clock used by the media renderer to synchronize audio/video frames. However HTML uses float values in the API to control media playback.

  • epoch should be milliseconds since the epoch (positive or negative). It could be a float64 or an int64.
  • duration and currentTime could be a float64 to align with HTML. It depends on whether it's the responsibility of the remote playback controller or the remote playback renderer to convert between media-time and seconds on the media timeline.
  • Similar case for the media time ranges - they should follow whatever is done for currentTime.
  • I think we should use null to represent an unknown value instead of having a separate type field. We can't just omit the field because that means "no change from previous state update."

As part of this PR the spec should propose how time values should be converted to/from media-time for use in the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant