Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Move weights mapper #11443

Merged
merged 3 commits into from
Dec 24, 2024
Merged

[Misc] Move weights mapper #11443

merged 3 commits into from
Dec 24, 2024
+74 −68

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Dec 24, 2024 •
edited by github-actions bot
Loading

Waiting for #11430 to merge

@jeejeelee
Done
b8fdc15 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Done
e5de5e9 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee marked this pull request as draft December 24, 2024 01:02
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Sync main
6be021d 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee marked this pull request as ready for review December 24, 2024 10:37
DarkLight1337
DarkLight1337 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with the refactoring!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 24, 2024 10:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 24, 2024
@DarkLight1337 DarkLight1337 merged commit 196c34b into vllm-project:main Dec 24, 2024
55 of 58 checks passed
@jeejeelee jeejeelee deleted the move-weights-mapper branch December 24, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeejeelee @DarkLight1337