Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix Qwen2-VL LoRA weight loading #11430

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Dec 23, 2024

FIX #11406

Upcoming PRs include:

  • Convert hf_to_vllm_mapper to static variable for all models
  • Support substr and subfix mapping

Signed-off-by: Jee Jee Li <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Thanks for fixing! Can you add a LoRA test for this model to avoid regressions?

@jeejeelee
Copy link
Collaborator Author

Thanks for fixing! Can you add a LoRA test for this model to avoid regressions?

Sure

Signed-off-by: Jee Jee Li <[email protected]>
vllm/lora/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 24, 2024 05:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 24, 2024
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Copy link
Collaborator Author

@DarkLight1337 All lora tests have passed

@DarkLight1337 DarkLight1337 merged commit b1b1038 into vllm-project:main Dec 24, 2024
58 checks passed
@jeejeelee jeejeelee deleted the qwen2-vl-lora branch December 24, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [0.6.5] Qwen2-VL LoRA Adapters does not take effect.
2 participants