Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(turbopack): Delete to-resolved-in-loop lint (too low signal) #74113

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Dec 19, 2024

Had a discussion with @sokra about this during office hours. We were in agreement to delete this, not because it's usually wrong, but just because it's not high-signal enough:

  • Many instances of to_resolved().await are on simple constructor calls, so it doesn't really matter if they're sequential. We could add some heuristics for this, but they'd be imperfect.
  • to_resolved().await isn't actually what drives the work forward, it's the function call that schedules the work, so in some cases this isn't accurate (and you can't know without type information).
  • This would make more sense if we were typically starved for work, but usually we have more tokio tasks than we can process anyways, so increasing parallelism is unlikely to help in most cases.
  • Some code isn't performance sensitive (e.g. internal CLI utilities, tests), so this is just noise in those places.

Closes PACK-3678

@ijjk
Copy link
Member

ijjk commented Dec 19, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
buildDuration 20.5s 18.9s N/A
buildDurationCached 17.9s 15.4s N/A
nodeModulesSize 416 MB 416 MB
nextStartRea..uration (ms) 516ms 493ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 537 B
withRouter.html gzip 518 B 520 B N/A
Overall change 537 B 537 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
middleware-b..fest.js gzip 669 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 348 kB 348 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB
build cache
vercel/next.js canary vercel/next.js bgw/rm-to-resolved-in-loop-lint Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.3 kB 73.8 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: d4277f7

@ijjk
Copy link
Member

ijjk commented Dec 19, 2024

Tests Passed

@bgw bgw force-pushed the bgw/improve-to-resolved-in-loop branch from d9c8c34 to 89838c8 Compare December 20, 2024 01:50
@bgw bgw force-pushed the bgw/rm-to-resolved-in-loop-lint branch from cd88f0f to 1495219 Compare December 20, 2024 01:50
@bgw bgw force-pushed the bgw/improve-to-resolved-in-loop branch 2 times, most recently from 8648a59 to 89c39b2 Compare December 20, 2024 02:06
@bgw bgw force-pushed the bgw/rm-to-resolved-in-loop-lint branch from 1495219 to 7fd7067 Compare December 20, 2024 02:06
@bgw bgw changed the base branch from bgw/improve-to-resolved-in-loop to graphite-base/74113 December 20, 2024 03:20
@bgw bgw force-pushed the graphite-base/74113 branch from 89c39b2 to bc69d97 Compare December 20, 2024 03:21
@bgw bgw force-pushed the bgw/rm-to-resolved-in-loop-lint branch from 7fd7067 to 7e978f9 Compare December 20, 2024 03:21
@bgw bgw changed the base branch from graphite-base/74113 to canary December 20, 2024 03:21
@bgw bgw force-pushed the bgw/rm-to-resolved-in-loop-lint branch from 7e978f9 to d4277f7 Compare December 20, 2024 03:21
@bgw bgw merged commit c004041 into canary Dec 20, 2024
126 of 131 checks passed
Copy link
Member Author

bgw commented Dec 20, 2024

Merge activity

  • Dec 19, 11:23 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/rm-to-resolved-in-loop-lint branch December 20, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants