Skip to content

Commit

Permalink
chore(turbopack): Delete to-resolved-in-loop lint (too low signal) (#…
Browse files Browse the repository at this point in the history
…74113)

Had a discussion with @sokra about this during office hours. We were in agreement to delete this, not because it's usually wrong, but just because it's not high-signal enough:

- Many instances of `to_resolved().await` are on simple constructor calls, so it doesn't really matter if they're sequential. We could add some heuristics for this, but they'd be imperfect.
- `to_resolved().await` isn't actually what drives the work forward, it's the function call that schedules the work, so in some cases this isn't accurate (and you can't know without type information).
- This would make more sense if we were typically starved for work, but usually we have more tokio tasks than we can process anyways, so increasing parallelism is unlikely to help in most cases.
- Some code isn't performance sensitive (e.g. internal CLI utilities, tests), so this is just noise in those places.
  • Loading branch information
bgw authored Dec 20, 2024
1 parent ad2282d commit c004041
Showing 1 changed file with 0 additions and 30 deletions.
30 changes: 0 additions & 30 deletions .config/ast-grep/rules/to-resolved-in-loop.yml

This file was deleted.

0 comments on commit c004041

Please sign in to comment.