Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fixes + explicit option balance check #100

Merged
merged 9 commits into from
Nov 16, 2022
+121 −170
Merged

test fixes + explicit option balance check #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2f131f4
fix failing test
Flip-Liquid Nov 16, 2022
b5835ae
test fixes, slight refac
Flip-Liquid Nov 16, 2022
70ba0ba
fix warngings and tests
Flip-Liquid Nov 16, 2022
21793f6
drop unused error; assert div error for no claims written
Flip-Liquid Nov 16, 2022
c420993
drop TODOs; fix tests
Flip-Liquid Nov 16, 2022
f07470a
lint
Flip-Liquid Nov 16, 2022
0d8ba3b
fix double claim test
Flip-Liquid Nov 16, 2022
4191209
drop dead code
Flip-Liquid Nov 16, 2022
09ee3c9
fix lint
Flip-Liquid Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/interfaces/IOptionSettlementEngine.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,6 @@ interface IOptionSettlementEngine {
*/
error ExerciseTooEarly(uint256 optionId, uint40 exercise);

/**
* @notice This option has no claims written against it.
* @param optionId Supplied option ID.
*/
error NoClaims(uint256 optionId);

/**
* @notice This claim is not owned by the caller.
* @param claimId Supplied claim ID.
Expand Down
Loading