Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fixes + explicit option balance check #100

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Conversation

Flip-Liquid
Copy link
Contributor

Addresses #77

removes dead code

Adds explicit error code for fungible options balance

@codecov-commenter
Copy link

Codecov Report

Merging #100 (09ee3c9) into master (fafa5ac) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   85.10%   84.52%   -0.58%     
==========================================
  Files           3        3              
  Lines         349      349              
  Branches       52       52              
==========================================
- Hits          297      295       -2     
- Misses         40       41       +1     
- Partials       12       13       +1     
Impacted Files Coverage Δ
test/OptionSettlement.t.sol 0.00% <ø> (ø)
src/OptionSettlement.sol 93.57% <0.00%> (-0.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@0xAlcibiades 0xAlcibiades merged commit ba90894 into master Nov 16, 2022
@0xAlcibiades 0xAlcibiades deleted the master_test_fixes branch November 19, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants