Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use quarkus compatible classloader #149

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: use quarkus compatible classloader #149

merged 2 commits into from
Apr 11, 2024

Conversation

caalador
Copy link
Contributor

Use a classLoader that is
compatible with quarkus for
default i18N translation.

part of vaadin/flow#18977

@caalador
Copy link
Contributor Author

Depends on vaadin/flow#19136
Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.

@mcollovati
Copy link
Contributor

Also proposes update add-on from 2.0 to 2.1 meaning that 2.0 should be branched out from main branch.

Is it reasonable to have two separated commits for version bump and the instantiator change and then do a rebase and merge instead of squash?

@caalador caalador force-pushed the issues/18977-i18n branch from 3a8bf62 to 9172fb4 Compare April 11, 2024 06:27
@mcollovati
Copy link
Contributor

A minor nit: swapping the order of the commits would make both of them compilable once we have the new Flow snapshot. With the current order (first code changes than Flow bump) the first commit will be broken.

@caalador caalador force-pushed the issues/18977-i18n branch from 9172fb4 to 181d81b Compare April 11, 2024 09:30
@mcollovati
Copy link
Contributor

It would be nice to add I18n test (normal usage + background thread), but we can do it in another PR.
Probably there are also other features missing some test

@caalador caalador marked this pull request as ready for review April 11, 2024 10:18
@caalador caalador force-pushed the issues/18977-i18n branch 3 times, most recently from 8d36062 to cd3a6cb Compare April 11, 2024 11:21
Use a classLoader that is
compatible with quarkus for
default i18N translation.

part of vaadin/flow#18977
@caalador caalador force-pushed the issues/18977-i18n branch from cd3a6cb to 90717c4 Compare April 11, 2024 11:28
@caalador
Copy link
Contributor Author

Now the test is there and the assertions should be build in the correct order.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@caalador caalador merged commit d7ac1aa into master Apr 11, 2024
3 checks passed
@caalador caalador deleted the issues/18977-i18n branch April 11, 2024 15:08
@vaadin-bot
Copy link

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d7ac1aa
error: could not apply d7ac1aa... fix: use quarkus compatible classloader
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@mcollovati
Copy link
Contributor

Was already picked manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants