-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use quarkus compatible classloader #149
Conversation
Depends on vaadin/flow#19136 |
Is it reasonable to have two separated commits for version bump and the instantiator change and then do a |
3a8bf62
to
9172fb4
Compare
A minor nit: swapping the order of the commits would make both of them compilable once we have the new Flow snapshot. With the current order (first code changes than Flow bump) the first commit will be broken. |
9172fb4
to
181d81b
Compare
It would be nice to add I18n test (normal usage + background thread), but we can do it in another PR. |
8d36062
to
cd3a6cb
Compare
Use a classLoader that is compatible with quarkus for default i18N translation. part of vaadin/flow#18977
cd3a6cb
to
90717c4
Compare
Now the test is there and the assertions should be build in the correct order. |
Quality Gate passedIssues Measures |
Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.0, i have encountered the following issue. Can you take a look and pick it manually? |
Was already picked manually |
Use a classLoader that is
compatible with quarkus for
default i18N translation.
part of vaadin/flow#18977