Skip to content

Commit

Permalink
fix: use quarkus compatible classloader
Browse files Browse the repository at this point in the history
Use a classLoader that is
compatible with quarkus for
default i18N translation.

part of vaadin/flow#18977
  • Loading branch information
caalador committed Apr 11, 2024
1 parent 8595c07 commit 3a8bf62
Show file tree
Hide file tree
Showing 14 changed files with 22 additions and 17 deletions.
2 changes: 1 addition & 1 deletion build-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-buildtools</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion deployment/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-deployment</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/codestarts/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-codestarts-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/common-test-code/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-common-test-code</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/custom-websocket-dependency/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion integration-tests/development/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-development-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-integration-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/production/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus-production-tests</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/reusable-theme/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<modelVersion>4.0.0</modelVersion>
Expand All @@ -16,7 +16,7 @@

<properties>
<maven.deploy.skip>true</maven.deploy.skip>
<vaadin-lumo-theme.version>24.0-SNAPSHOT</vaadin-lumo-theme.version>
<vaadin-lumo-theme.version>24.4-SNAPSHOT</vaadin-lumo-theme.version>
</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/test-addons/addon-with-jandex/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion integration-tests/test-addons/addon-without-jandex/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-integration-tests</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
<packaging>pom</packaging>

<name>Vaadin Quarkus - Parent</name>
Expand All @@ -34,7 +34,7 @@
<failsafe-plugin.version>${surefire-plugin.version}</failsafe-plugin.version>
<maven.compiler.parameters>true</maven.compiler.parameters>

<vaadin.flow.version>24.0-SNAPSHOT</vaadin.flow.version>
<vaadin.flow.version>24.4-SNAPSHOT</vaadin.flow.version>
<quarkus.version>3.0.1.Final</quarkus.version>
<open.telemetry.alpha.version>1.16.0-alpha</open.telemetry.alpha.version>
<open.telemetry.version>1.16.0</open.telemetry.version>
Expand Down
2 changes: 1 addition & 1 deletion runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-quarkus-parent</artifactId>
<version>2.0-SNAPSHOT</version>
<version>2.1-SNAPSHOT</version>
</parent>

<artifactId>vaadin-quarkus</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,13 @@ public Instantiator createInstantitor(VaadinService vaadinService) {
if (!getServiceClass().isAssignableFrom(vaadinService.getClass())) {
return null;
}
return new QuarkusInstantiator(new DefaultInstantiator(vaadinService),
beanManager);
DefaultInstantiator delegate = new DefaultInstantiator(vaadinService) {
@Override
protected ClassLoader getClassLoader() {
return Thread.currentThread().getContextClassLoader();
}
};
return new QuarkusInstantiator(delegate, beanManager);
}

/**
Expand Down

0 comments on commit 3a8bf62

Please sign in to comment.