Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-build production bundle if index.html changes (#20729) (CP: 24.4) #20738

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Stores index.html hash in stats.json and forces production bundle to be
re-built if file contents have changed. Changes to index.html do not
trigger a dev bundle re-generation since in dev mode the file is served
directly from the frontend folder.

Fixes #20629
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 18, 2024 06:26
Copy link

Test Results

1 120 files  ±0  1 120 suites  ±0   1h 22m 17s ⏱️ - 2m 6s
7 137 tests +6  7 085 ✅ +4  52 💤 +2  0 ❌ ±0 
7 481 runs  +1  7 417 ✅  - 3  64 💤 +4  0 ❌ ±0 

Results for commit a86b7ba. ± Comparison against base commit 3780df1.

@vaadin-bot vaadin-bot merged commit 1e0ab0b into 24.4 Dec 18, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20729-to-24.4-1734502533773 branch December 18, 2024 06:31
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants