-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-build production bundle if index.html changes #20729
Conversation
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629
If this change gets merged, we need to check and potentially update the index.html file in starters to match the default contents, to prevent a custom production bundle to be generated if not needed. For example, https://github.com/vaadin/skeleton-starter-flow-spring/blob/v24/src/main/frontend/index.html |
Quality Gate passedIssues Measures |
@caalador I was thinking if we should remove indentation and comments before hashing, to prevent irrelevant changes causing a bundle rebuild. What do you think? |
removing comments might be a bit too much for running the check and hash creation. trimming might be fine, but it will make it more complex than now when we only read and hash. |
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629 Co-authored-by: Marco Collovati <[email protected]>
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629 Co-authored-by: Marco Collovati <[email protected]>
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed. Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder. Fixes #20629 Co-authored-by: Marco Collovati <[email protected]>
Stores index.html hash in stats.json and forces production bundle to be re-built if file contents have changed.
Changes to index.html do not trigger a dev bundle re-generation since in dev mode the file is served directly from the frontend folder.
Fixes #20629