Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle logout from a background thread (#20688) (CP: 24.5) #20706

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) December 13, 2024 15:39
Copy link

github-actions bot commented Dec 13, 2024

Test Results

1 148 files  ± 0  1 148 suites  ±0   1h 27m 16s ⏱️ + 3m 11s
7 522 tests + 5  7 471 ✅ + 5  51 💤 ±0  0 ❌ ±0 
7 893 runs  +17  7 832 ✅ +17  61 💤 ±0  0 ❌ ±0 

Results for commit abde28f. ± Comparison against base commit 5804162.

♻️ This comment has been updated with latest results.

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 6a94f63 into 24.5 Dec 16, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20688-to-24.5-1734103957398 branch December 16, 2024 08:04
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants