Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle logout from a background thread #20688

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mcollovati
Copy link
Collaborator

Description

Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mcollovati
Copy link
Collaborator Author

Currently in draft because it is based on #20679, but the ready for review.

Copy link

github-actions bot commented Dec 12, 2024

Test Results

1 159 files  ± 0  1 159 suites  ±0   1h 29m 54s ⏱️ - 2m 45s
7 562 tests + 5  7 508 ✅ + 5  54 💤 ±0  0 ❌ ±0 
7 894 runs  +15  7 833 ✅ +16  61 💤  - 1  0 ❌ ±0 

Results for commit 789bacf. ± Comparison against base commit 5ff8cf5.

♻️ This comment has been updated with latest results.

Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026
@mcollovati mcollovati force-pushed the issues/11026-logout_from-background-thread branch from f0ec738 to 789bacf Compare December 13, 2024 14:56
@mcollovati mcollovati marked this pull request as ready for review December 13, 2024 14:57
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Dec 13, 2024
@mshabarov mshabarov enabled auto-merge (squash) December 13, 2024 15:24
@mshabarov mshabarov merged commit afd284b into main Dec 13, 2024
25 of 26 checks passed
@mshabarov mshabarov deleted the issues/11026-logout_from-background-thread branch December 13, 2024 15:27
vaadin-bot pushed a commit that referenced this pull request Dec 13, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026
vaadin-bot pushed a commit that referenced this pull request Dec 13, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026
vaadin-bot pushed a commit that referenced this pull request Dec 13, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026
vaadin-bot added a commit that referenced this pull request Dec 16, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026

Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot added a commit that referenced this pull request Dec 16, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026

Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot added a commit that referenced this pull request Dec 16, 2024
Allows AuthenticationContext.logout feature to be used from a background thread,
handling the missing request by forcing the client to make an additional request.
Applies the same logic used to support logout when using PUSH with websocket
transport.

References #11026

Co-authored-by: Marco Collovati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants