fix: Pass route data through window.Vaadin.routesConfig instead of an import (#19666) (CP: 24.4) #19670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… import (#19666) Instead of importing routes.js/routes.ts/routes.tsx from the project into Flow.tsx and creating a circular dependency, this moves importing of routes.js to a new file that is always included when react is used vaadin-react.tsx. This file publishes the routes as window.Vaadin.routesConfig so that Flow.tsx can read them from there without directly depending on routes.js Fixes #19658
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
vaadin-review-bot
approved these changes
Jul 4, 2024
|
|
This ticket/PR has been released with Vaadin 24.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.