fix: Pass route data through window.Vaadin.routesConfig instead of an import #19666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
routes-through-global
branch
from
acc4061 to
4a11fa2
Compare
mshabarov
reviewed
Jul 4, 2024
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
|
mshabarov
approved these changes
Jul 4, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
… import (#19666) Instead of importing routes.js/routes.ts/routes.tsx from the project into Flow.tsx and creating a circular dependency, this moves importing of routes.js to a new file that is always included when react is used vaadin-react.tsx. This file publishes the routes as window.Vaadin.routesConfig so that Flow.tsx can read them from there without directly depending on routes.js Fixes #19658
vaadin-bot
added a commit
that referenced
this pull request
Jul 4, 2024
… import (#19666) (#19670) Instead of importing routes.js/routes.ts/routes.tsx from the project into Flow.tsx and creating a circular dependency, this moves importing of routes.js to a new file that is always included when react is used vaadin-react.tsx. This file publishes the routes as window.Vaadin.routesConfig so that Flow.tsx can read them from there without directly depending on routes.js Fixes #19658 Co-authored-by: Artur <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of importing
routes.js/routes.ts/routes.tsxfrom the project intoFlow.tsxand creating a circular dependency, this moves importing ofroutes.jsto a new file that is always included when react is usedvaadin-react.tsx. This file publishes the routes aswindow.Vaadin.routesConfigso thatFlow.tsxcan read them from there without directly depending onroutes.jsFixes #19658