Project-wide build fixes and tweaks #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he match Rust 1.62 almost all of the nightly const fn features we required have been stabilized
now that `OS_CONST` can be const by default, we can do away with the `lazy_static!` `OS`!
the `const_panic` crate gives us the functionality we want on stable this was the last thing blocking `--all-features` from building on stable
these have effectively already moved to the `tm4c` repo
(this are all the version bumps that did *not* require any changes in the codebase)
whatever LLVM bug we were hitting with `black_box` seems to be resolved?
cosmetic changes only
we actually had a little breakage! (`a'b` now parses `a` as a string/character prefix)
the comment in .cargo/config outlines the upsides and downsides pretty
well but just to recap, quickly:
- this is nice because it lets us:
+ avoid duplicating the same list of lints across all the crates
+ avoid blocking the build on these lints passing
+ give developers an easy way to run the same set of lints that
CI will run without needing to push/make a PR/etc.
- the downsides are that:
+ this does not integrate with your editor
in the future we'd want a solution like clippy.toml
if we're okay with requiring that developers install something,
cargo-cranky works today and works great as a `cargo clippy` replacement
with rust-analyzer so you can get the lint errors in your editor
but for now, this will do
the comments explain; similar kind of thing as the regular lints
gipsond
reviewed
Jul 13, 2022
| @@ -381,7 +381,7 @@ mod tests { | |||
| #[test] | |||
| fn misc() { | |||
| let insn = | |||
| insn!(AND R0, R0, R0, => Unfortunately we'll take trailing commas, but don't do this!); | |||
| insn!(AND R0, R0, R0, => Unfortunately we will take trailing commas, but please do not do this!); | |||
There was a problem hiding this comment.
Thank you, Rust 2021, for enforcing formal writing... in our macro invocations.
pranav12321
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for another hefty PR. This is mostly just mechanical changes, the commits more or less describe what's going on.
Highlights are:
nightlyin the project have been removed; this lets us use--all-featureswith abandoncargo build(andcargo test) is now completely quietrustcemits; the warn-by-default lints are quite good and have actually caught many of the mistakes we've made in the past (we just didn't notice because we had so many warnings).cargo/configand no longer block the build.cargo/confighas a discussion of the tradeoffs involvedcargo lintyetcargoaliases (documented in the README)cargoaliases