Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy clean #170

Open
11 tasks
rrbutani opened this issue Jul 25, 2022 · 0 comments
Open
11 tasks

Clippy clean #170

rrbutani opened this issue Jul 25, 2022 · 0 comments
Assignees
Labels
➕ improvement Chores and fixes: the small things. 🔧 infra Project infrastructure, meta, dev-ex, etc. P-low Low priority 📜 tracking Tracking issue: an issue full of other issues
Milestone

Comments

@rrbutani
Copy link
Member

what

Tracking issue for cargo lint showing all green.

#167 fixed all the default rustc warnings and errors across our crates. dc714eaeaa180a5f0606239d09c3ef91e732f2cd and b76341cb528b6c0066945e191f03c1c28c43d730 then added some extra lints that don't block the build but that we hope to gate CI on.

steps

The first step is to get all the lints passing; we're going to do this on a crate by crate basis:

  • application-support ()
  • baseline-sim ()
  • benches ()
  • device-support ()
  • isa ()
  • macros ()
  • os ()
  • shims ()
  • test-infrastructure ()
  • traits ()

Next we can:

  • take another look at the clippy lints and see if there's anything else we want to enforce
@rrbutani rrbutani added the ➕ improvement Chores and fixes: the small things. label Jul 25, 2022
@rrbutani rrbutani added this to the Clippy clean milestone Jul 25, 2022
@rrbutani rrbutani self-assigned this Jul 25, 2022
@rrbutani rrbutani added P-low Low priority 🔧 infra Project infrastructure, meta, dev-ex, etc. labels Jul 25, 2022
This was referenced Jul 25, 2022
@rrbutani rrbutani added the 📜 tracking Tracking issue: an issue full of other issues label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ improvement Chores and fixes: the small things. 🔧 infra Project infrastructure, meta, dev-ex, etc. P-low Low priority 📜 tracking Tracking issue: an issue full of other issues
Projects
Status: No status
Development

No branches or pull requests

1 participant