Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce some lints with forbid #113

Closed
22 tasks
gipsond opened this issue May 24, 2020 · 1 comment
Closed
22 tasks

Enforce some lints with forbid #113

gipsond opened this issue May 24, 2020 · 1 comment
Assignees
@rrbutani
Labels
➕ improvement Chores and fixes: the small things. question Further information is requested

Comments

@gipsond
Copy link
Contributor

gipsond commented May 24, 2020

what

We would like to enforce the lints listed under "steps" with forbid.

steps

  • Pass the lints in each crate.
    • bad_style
    • const_err
    • dead_code
    • improper_ctypes
    • legacy_directory_ownership
    • non_shorthand_field_patterns
    • no_mangle_generic_items
    • overflowing_literals
    • path_statements
    • patterns_in_fns_without_body
    • plugin_as_library
    • private_in_public
    • safe_extern_statics
    • unconditional_recursion
    • unused
    • unused_allocation
    • unused_lifetimes
    • unused_comparisons
    • unused_parens
    • while_tru
  • Change the lint level of these lints to forbid in each crate.

where

branch: N/A

open questions

  • Should we consider only enforcing some of these lints at deny or warn level?
  • Should this be a milestone, with separate issues for each lint?
@gipsond gipsond added the ➕ improvement Chores and fixes: the small things. label May 24, 2020
@gipsond gipsond added the question Further information is requested label May 24, 2020
@rrbutani
Copy link
Member

Closing this in favor of #170.

@rrbutani rrbutani closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrbutani rrbutani

Labels
➕ improvement Chores and fixes: the small things. question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrbutani @gipsond