feat(core): Allow GET URL limit to be ignored using force option #2692
Conversation
🦋 Changeset detectedLatest commit: 517cac7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -40,7 +40,7 @@ export const makeFetchURL = ( | |||
| search.set('extensions', stringifyVariables(body.extensions)); | |||
|
|
|||
| const finalUrl = url.toString(); | |||
| if (finalUrl.length > 2047) { | |||
| if (finalUrl.length > 2047 && useGETMethod !== 'force') { | |||
There was a problem hiding this comment.
Do we want to allow people to specify their own limit or are we just going to leave it to the escape-hatch?
There was a problem hiding this comment.
I don't really see personally why someone would have a different limit than the defacto IETF limit on the length of URLs, which also happens to be one that all browsers align on 🤔
I think the main reason we're adding this is if someone knows their entire stack can support variable length URLs, in which case, worst case, they're opting into HTTP stack errors, which are very observable. Most likely, I'd expect to see this in backend-only applications where likely no limit really applies if someone knows their stack supports longer URLs
Resolve #2680
Summary
This updates
preferGetMethodto allow for one more mode, which ignores the URL size limit of 2048 characters.The option now, apart from boolean flags, also accepts
preferGetMethod: 'within-url-limit'andpreferGetMethod: 'force'. This is the proposed method to allow fetch exchanges to bypass the defined limit and always send a GET request for queries.The default remains unchanged at
preferGetMethod: true | 'within-url-limit'Set of changes
preferGetMethodpreferGetMethod: 'force'