Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Configurable url-size limit #2680

Closed
c-schwan opened this issue Sep 16, 2022 · 1 comment · Fixed by #2692
Closed

RFC: Configurable url-size limit #2680

c-schwan opened this issue Sep 16, 2022 · 1 comment · Fixed by #2692
Labels
future 🔮 An enhancement or feature proposal that will be addressed after the next release

Comments

@c-schwan
Copy link
Contributor

Summary

#2384 (comment)

its a hardcoded limitation

In our case we don't need to limit the url size because its an internal graphql request.
With the limitation its not possible to force GET requests.

Proposed Solution

Please accept a new parameter (eg "urlSizeLimit")

@c-schwan c-schwan added the future 🔮 An enhancement or feature proposal that will be addressed after the next release label Sep 16, 2022
@JoviDeCroock
Copy link
Collaborator

JoviDeCroock commented Sep 21, 2022

We can do this yeah, we have the hard-coded limitation in-place so people don't run into this issue head-first as browsers have their own limitations and servers do too 😅

Example

Microsoft Internet Explorer: 2,083 characters
Microsoft Edge: 2,083 characters
Google Chrome: 32,779 characters
Mozilla Firefox: more than 64,000 characters
Apple Safari: more than 64,000 characters
Google Android: 8,192 characters

2000 characters seems to be the general policy to avoid these issues in servers, cdns and browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future 🔮 An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants