-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Base resolution #262
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
64f0c7c
feat: support Base resolution
sammyluo 75b9498
feat: add reverse resolution priority
sammyluo 1affbec
feat: load tld naming service from /supported_tlds API
sammyluo d370575
test: fix test
sammyluo d8665a4
fix: test
sammyluo abd3c72
fix: test
sammyluo 3ace940
chore: optional blockchain type for uns source config
sammyluo d495e81
chore: changelog update
sammyluo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
L1_TEST_NET_RPC_URL=https://goerli.infura.io/v3/<your_key> | ||
L1_TEST_NET_RPC_WSS_URL=wss://goerli.infura.io/ws/v3/<your_key> | ||
L2_TEST_NET_RPC_URL=https://polygon-mumbai.infura.io/v3/<your_key> | ||
L2_TEST_NET_RPC_WSS_URL=wss://polygon-mumbai.g.alchemy.com/v2/<your_key> | ||
L1_TEST_NET_RPC_URL=https://sepolia.infura.io/v3/<your_key> | ||
L1_TEST_NET_RPC_WSS_URL=wss://sepolia.infura.io/ws/v3/<your_key> | ||
L2_TEST_NET_RPC_URL=https://polygon-amoy.infura.io/v3/<your_key> | ||
L2_TEST_NET_RPC_WSS_URL=wss://polygon-amoy.g.alchemy.com/v2/<your_key> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,7 +99,7 @@ export default class Uns extends NamingService { | |
this.unsl2 = new UnsInternal( | ||
UnsLocation.Layer2, | ||
source.locations.Layer2, | ||
BlockchainType.MATIC, | ||
BlockchainType.POL, | ||
); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this is going to be |
||
} | ||
|
||
|
@@ -447,7 +447,7 @@ export default class Uns extends NamingService { | |
|
||
private async getMetadata(tokenId: string): Promise<DomainMetadata> { | ||
const tokenUri = await this.getTokenUri(tokenId); | ||
const resp = await Networking.fetch(tokenUri, {}).catch((err) => { | ||
const resp = await Networking.fetch(tokenUri).catch((err) => { | ||
throw new ResolutionError(ResolutionErrorCode.MetadataEndpointError, { | ||
tokenUri: tokenUri || 'undefined', | ||
errorMessage: err.message, | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider making one of the "layers" optional for cases similar to Base where we know that domains can exist only on one chain.
This will save us some RPC calls on querying L1 when we don't need to.