feat: support Base resolution #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DancingAxolotl
approved these changes
Oct 22, 2024
src/Resolution.ts
Outdated
Comment on lines
1220
to
1234
| return new Uns({ | ||
| locations: { | ||
| Layer1: { | ||
| url: `${DEFAULT_UNS_PROXY_SERVICE_URL}/chains/eth/rpc`, | ||
| network: 'mainnet', | ||
| proxyServiceApiKey: config.apiKey, | ||
| }, | ||
| Layer2: { | ||
| url: `${DEFAULT_UNS_PROXY_SERVICE_URL}/chains/base/rpc`, | ||
| network: 'base-mainnet', | ||
| proxyServiceApiKey: config.apiKey, | ||
| }, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
We can consider making one of the "layers" optional for cases similar to Base where we know that domains can exist only on one chain.
This will save us some RPC calls on querying L1 when we don't need to.
src/Uns.ts
Outdated
Comment on lines
99
to
103
| this.unsl2 = new UnsInternal( | ||
| UnsLocation.Layer2, | ||
| source.locations.Layer2, | ||
| BlockchainType.MATIC, | ||
| BlockchainType.POL, | ||
| ); |
There was a problem hiding this comment.
Looks like this is going to be POL for both Polygon and Base configs. It's probably fine as is, but might be worth passing the blockchain type into constructor args.
sammyluo
force-pushed
the
sam/api-1177-base-support
branch
from
05a9313 to
d495e81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Support domain resolution for UNS domains on Base blockchain
Changes
To Do
Additional Deployment and/or Rollback Steps
Code Review
This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:
Please select all applied standards relevant to this PR.
Confirmation