Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the element picker to show the rule in full form #1018

Closed
5 of 8 tasks
peace2000 opened this issue May 10, 2020 · 6 comments
Closed
5 of 8 tasks

Make the element picker to show the rule in full form #1018

peace2000 opened this issue May 10, 2020 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@peace2000
Copy link
Member

peace2000 commented May 10, 2020

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

I suggest that the element picker of Ubo would be changed so that it shows the rule it's about to make, in full form, including the domain part. This would increase userfriendliness when those rules are copied to separate lists. Now, every time I want to copy the rule in the element picker to a separate list, I have to either manually type the domain part to that rule or create the rule and then go to my own filters and copy the full form rule from there to a desired location. If the element picker would show the rule in full form, it would decrease unnecessary manual work.

So instead of this:

kuva

The picker would work like this:

kuva

I would be very happy if at least there would be a setting or a toggle to permanently enable this. :)

A specific URL where the issue occurs

Steps to Reproduce

  1. Open the element picker
  2. Click any element on a website
  3. Notice that the domain part is missing

Expected behavior:

The picker would show the rule in full form, including the domain

Actual behavior:

The domain part is not shown.

Your environment

  • uBlock Origin version: 1.26.3rc7
  • Browser Name and version: Firefox 76.0.1
  • Operating System and version: Windows 10
@gorhill
Copy link
Member

gorhill commented May 10, 2020

Related: gorhill/uBlock#2035

I had this idea to solve related issue above by using CodeMirror's ability to embed widget in the text flow, and the hostname part would be always shown inline but as a dropdown list widget in text editable text area -- this is something I still need to experiment with to find out if it's feasible.

@peace2000
Copy link
Member Author

Made a reference picture what I had in my mind when I spoke about a toggle:

https://images2.imgbox.com/89/50/F39Il4Ad_o.gif

But anyway - we'll see what you find the most reasonable option. :)

@uBlock-user uBlock-user added the enhancement New feature or request label May 10, 2020
@Yuki2718
Copy link

Also note the picker can create network rules but request-type options such as $image or $frame are currently not shown.

@Yuki2718
Copy link

Yuki2718 commented Jun 1, 2020

As a related matter, if the same path is used by both iframe and img the picker highlights both but the rule created is img only. An example:
[NSFW] http://buhidoh.net/

buhidoh

This is somewhat counter-intuitive and suggested change may fix it.

@yourduskquibbles
Copy link

However, issue #1018 could be considered a duplicate of gorhill/uBlock#2035.

Originally posted by @gorhill in #1277 (comment)

@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#2035

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#2035 Oct 7, 2020
@uBlock-user uBlock-user added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants