-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to automatically remove 'www' prefix from GUI-made rules #1277
Comments
Quasi-related open issue from old issue tracker: gorhill/uBlock#2035 |
Maybe not quite a dupe though since this is about enable/disable options on popup panel vs creating rules through element picker? |
Right, never mind, read to fast. |
Duplicate of gorhill/uBlock#2035 |
Not a duplicate, one concerns the picker while the other concerns rule-making -- it's not the same code involved. However, issue #1018 could be considered a duplicate of gorhill/uBlock#2035. |
Just thought I'd chime in on this enhancement request since I frequently check back to see if there's ever an update on it. I think this enhancement is potentially one of the biggest hurdles to using medium mode for a lot of semi-casual/semi-competent users. Of course I don't have any real data on this, but it's a hunch based on my own experiences with friends & family I try to push towards using medium mode. Every single one of them have found it exhausting to control individual subdomains. I am a medium mode user myself, and I understand that I control each subdomain with separate rules. I like it too. On some sites when I know I want all subdomains to follow the same rules as the root domain, I go into the rule list to manually remove the subdomain from the URL. Easy enough. But I think for the semi-casual users who want to delve a little into having more control, it can be very tedious to have to keep changing rule settings any time a website redirects through an alternate subdomain. Enough to turn them off from it entirely. I think a simple toggle, right next to toggles like cosmetic filtering and javascript, that switches between controlling the specific subdomain or the root domain, would vastly improve the usability of medium mode for a lot of people. |
There's not enough space for another button, especially not on mobile. Besides, making this a per site toggle would probably cause too much confusion. A global setting would be simpler fer regular users. |
That may be the case too. Personally I think a per-site toggle with a global default is better, just like how the Javascript toggle works. Then the panel can just be adjusted to accommodate the button (second row/wider/etc). But I'm not committed to the idea, the more important thing was just starting a discussion about this first. |
I also have this issue, although I agree with the previous discussion that this doesn't warrant its own button. I have two suggestions: both would be advanced features, since I don't see normal users needing this kind of customization.
In both cases, it should be made clear to the end-user that their override applies to only the subdomain vs the entire domain; I'm not entirely too sure how to accomplish this clearly. Some thoughts I had were to use a color to indicate the change, make it explicitly indicate all subdomains will be filtered by writing These suggestions are not necessarily mutually exclusive. You could use the domain list from 2. to inform whether the GUI by default will show the whole domain versus the subdomain in 1. I would be willing to do (or at least try) the implementation devwork if this sounds like a good idea. |
Prerequisites
Description
I would like to suggest to add an option (maybe to the settings pane of the dashboard) so that the 'www' prefix gets automatically removed from a rule the user added per GUI. (I know that everything is possible using the text-based rule syntax, but not all of my users want to use them.)
Example: If one likes to allow javascript on the site
www.example.org
, one often wants it to be enabled forlogin.example.org
, too.A specific URL where the issue occurs
https://www.orange.fr
Steps to Reproduce
https://login.orange.fr
Expected behavior:
If one enables Javascript or other stuff per GUI for
www.example.org
, those settings should be effective forexample.org
(withoutwww
). This behaviour should be adjustable in the settings.Actual behavior:
One needs to enable settings for every single subdomain of a site.
Your environment
The text was updated successfully, but these errors were encountered: