This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: update min Node.js version to 12.0.0, add support for Node.js v17 #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
changed the title
davidmurdoch
changed the title
This also normalizes package-lock.json indentation to use tabs (which was more common already)
davidmurdoch
force-pushed
the
update-node
branch
from
610aad8 to
c942af9
Compare
MicaiahReid
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
Looks good! I think we're likely to have merge conflicts with this and my PR, #1513
|
The number of merge conflicts in this one that I resolved last night was sickening. haha |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.